feat: remove GG18 signing during ECDSA TSS recovery #4883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
force-pushed
the
WP-2954/fix-recovery
branch
3 times, most recently
from
c0684e7
to
fe4875a
Compare
zahin-mohammad
force-pushed
the
WP-2954/fix-recovery
branch
from
fe4875a
to
b550b28
Compare
zahin-mohammad
changed the title
zahin-mohammad
commented
Sep 3, 2024
| @@ -1,5 +1,4 @@ | |||
| export const ethLikeGG18Keycard = { | |||
| senderAddress: '0xf3243334a491b6558f3f2c791afecc6a5eb955fa', | |||
There was a problem hiding this comment.
Hardcoding these addresses hid a bug in the actual recover code.
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a gg18 -> dkls retrofit when performing a recovery tx.
TICKET: WP-2954