Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-bera): add bera token support #4914

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

adarsh312
Copy link
Contributor

@adarsh312 adarsh312 commented Sep 19, 2024

Ticket: WIN-3493

BGT is a governance token for BERA, it is based on the ERC20 standard

@adarsh312 adarsh312 requested review from a team as code owners September 19, 2024 05:28
@adarsh312 adarsh312 marked this pull request as draft September 19, 2024 05:28
Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic comment to flush this PR from my review queue. 🚽🚽🚽
Please re-request another review from the respective team(s) when you are ready for reviews.

Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush

Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr is in draft

@adarsh312 adarsh312 marked this pull request as ready for review September 30, 2024 07:04
@adarsh312 adarsh312 marked this pull request as draft September 30, 2024 07:09
@adarsh312 adarsh312 marked this pull request as ready for review September 30, 2024 07:24
}

/**
* Factory function for zkSync Sepolia testnet beraErc20 token instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: zksync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed it, i will fix it

'bera:bgt',
'BGT Token',
18,
// TODO: the mainnet contract address is still not available, adding placeholder here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a ticket for this TODO.

@zahin-mohammad
Copy link
Contributor

Update codeowners please for this new sdk module.

@adarsh312 adarsh312 merged commit d7c3394 into master Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants