feat(ton): add single nominator withdraw txn #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
2 times, most recently
from
587134c
to
845ce0a
Compare
ewangbitgo
reviewed
Sep 20, 2024
ewangbitgo
reviewed
Sep 20, 2024
ewangbitgo
reviewed
Sep 20, 2024
ewangbitgo
reviewed
Sep 20, 2024
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
6 times, most recently
from
54d7e50
to
a27999e
Compare
ewangbitgo
reviewed
Sep 23, 2024
ewangbitgo
reviewed
Sep 23, 2024
ewangbitgo
reviewed
Sep 25, 2024
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
2 times, most recently
from
f57e2bc
to
bb33dea
Compare
ewangbitgo
reviewed
Sep 26, 2024
| send(recipient: Recipient): SingleNominatorWithdrawBuilder { | ||
| this.transaction.recipient = recipient; | ||
| return this; | ||
| } |
There was a problem hiding this comment.
you need add a method for withdrawAmount, and build message payload internally. And return error if user is trying to set a message.
ewangbitgo
reviewed
Sep 26, 2024
| txBuilder.publicKey(testData.sender.publicKey); | ||
| txBuilder.expireTime(1234567890); | ||
| txBuilder.send(testData.recipients[0]); | ||
| txBuilder.setWithdrawMessage('1'); |
There was a problem hiding this comment.
where to set withdraw amount
There was a problem hiding this comment.
i split the message creation into setWithdrawAmount and setWithdrawMessage functions
ewangbitgo
reviewed
Sep 26, 2024
| txBuilder.bounceable(true); | ||
| const tx = await txBuilder.build(); | ||
| should.equal(tx.type, TransactionType.SingleNominatorWithdraw); | ||
| should.equal(tx.toJson().bounceable, true); |
There was a problem hiding this comment.
tx.toJson should have a withdraw amount decoded.
There was a problem hiding this comment.
added the checks
ewangbitgo
reviewed
Sep 26, 2024
| jsonTx.amount.should.equal('10000000'); | ||
| jsonTx.seqno.should.equal(6); | ||
| jsonTx.expirationTime.should.equal(1695997582); | ||
|
|
There was a problem hiding this comment.
you should add a withdraw amount in toJson and verify in this test.
ewangbitgo
reviewed
Sep 26, 2024
| }); | ||
|
|
||
| it('should build a signed withdraw tx and submit onchain', async function () { | ||
| const tonweb = new TonWeb(new TonWeb.HttpProvider('https://testnet.toncenter.com/api/v2/jsonRPC')); |
There was a problem hiding this comment.
disable this test for ci
ewangbitgo
reviewed
Sep 26, 2024
| const explainedTransaction = (await basecoin.explainTransaction({ | ||
| txHex: Buffer.from(testData.signedTransferTransaction.tx, 'base64').toString('hex'), | ||
| })) as TransactionExplanation; | ||
| explainedTransaction.should.deepEqual({ |
There was a problem hiding this comment.
you need add withdraw amount to explainTransaction for single nominator transaction
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
from
bb33dea
to
bc9ec3b
Compare
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
from
bc9ec3b
to
1a410f4
Compare
quarterdill
force-pushed
the
sc-370-implement-single-nominator-unstaking-txn
branch
from
1a410f4
to
f89be52
Compare
ewangbitgo
approved these changes
Sep 27, 2024
quarterdill
deleted the
sc-370-implement-single-nominator-unstaking-txn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SC-370
Add TON single nominator withdraw transaction