refactor(utxo-bin): improve yargs argument parsing #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-1351.utxo-bin-cleanup-args
branch
from
d5b73ca
to
240bd39
Compare
OttoAllmendinger
force-pushed
the
BTC-1351.utxo-bin-cleanup-args
branch
2 times, most recently
from
1e42a56
to
b33ae2a
Compare
Gets rid of some boilerplate to convert a string to a network object Issue: BTC-1351
OttoAllmendinger
force-pushed
the
BTC-1351.utxo-bin-cleanup-args
branch
from
b33ae2a
to
c37c2c3
Compare
OttoAllmendinger
changed the title
OttoAllmendinger
changed the title
saravanan7mani
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: factor out certain util funcs in utxo-bin
TICKET: BTC-1351
refactor: add argToString
Issue: BTC-1351
refactor: move argToString to parseString
Issue: BTC-1351
refactor: factor out readStringOptions
Issue: BTC-1351
refactor: move readStdin to parseString
Issue: BTC-1351
refactor: move parseString.ts to args/
Issue: BTC-1351
refactor: move walletKeys.ts to args/
Issue: BTC-1351
refactor: move getNetworkForName to args/
TICKET: BTC-1351
refactor: use getNetworkOptions(Demand) for network options
Gets rid of some boilerplate to convert a string to a network object
Issue: BTC-1351