Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk-coin-avaxc): add avaxc support for evm ccr #4953

Closed
wants to merge 6 commits into from
Closed

feat(sdk-coin-avaxc): add avaxc support for evm ccr #4953

wants to merge 6 commits into from

Conversation

nrjsuthar
Copy link

TICKET: COIN-1708

@nrjsuthar nrjsuthar requested a review from a team as a code owner September 26, 2024 17:40
Vijay-Jagannathan
Vijay-Jagannathan reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing some build

@venkateshv1266
Copy link
Contributor

Since there is a dependency addition in package.json, we might need to add package-lock.json file as well.

@venkateshv1266
Copy link
Contributor

Still some change is needed in the PR to by-pass fetching gasprice and gaslimit function call only for AVAXC in the file abstractEthLikeNewCoins.ts.
Here for gasPrice https://github.com/BitGo/BitGoJS/blob/COIN-1708/modules/abstract-eth/src/abstractEthLikeNewCoins.ts#L1529
Here for gasLimit (native): https://github.com/BitGo/BitGoJS/blob/COIN-1708/modules/abstract-eth/src/abstractEthLikeNewCoins.ts#L1639
Here for gasLimit (token): https://github.com/BitGo/BitGoJS/blob/COIN-1708/modules/abstract-eth/src/abstractEthLikeNewCoins.ts#L1808

If not, we are unable to generate half-signed transaction from WRW.

@nrjsuthar nrjsuthar force-pushed the COIN-1708 branch 2 times, most recently from 05e4b50 to e8dfa73 Compare October 1, 2024 06:52
@nrjsuthar nrjsuthar requested review from a team as code owners October 1, 2024 14:28
zahin-mohammad
zahin-mohammad requested changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there bera token commits for a pr for avaxc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vijay-Jagannathan Vijay-Jagannathan Vijay-Jagannathan left review comments

@zahin-mohammad zahin-mohammad zahin-mohammad requested changes

@OttoAllmendinger OttoAllmendinger OttoAllmendinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@nrjsuthar @venkateshv1266 @OttoAllmendinger @zahin-mohammad @Vijay-Jagannathan @adarsh312 @ranger2255 @Doddanna17 @Anupam-pandey @quarterdill