Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(statics): add new tokens #4960

Merged
merged 1 commit into from
Sep 30, 2024
Merged

feat(statics): add new tokens #4960

merged 1 commit into from
Sep 30, 2024

Conversation

baltiyal
Copy link
Contributor

@baltiyal baltiyal commented Sep 27, 2024 •
edited
Loading

Ticket: COIN-1744

@baltiyal baltiyal requested review from a team as code owners September 27, 2024 12:42
@baltiyal baltiyal force-pushed the COIN-1744-token-onboarding branch 3 times, most recently from 8788f7b to 10a79a6 Compare September 27, 2024 13:27
MohammedRyaan786
MohammedRyaan786 reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@MohammedRyaan786 MohammedRyaan786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tokens present in ticket but not added:

JASMY
POLYGON:OM
BSC:BTT
TRX:BTT
WFLOW
GT
XAUT

please add these as well

modules/statics/src/coins.ts Outdated Show resolved Hide resolved
modules/statics/src/coins.ts Show resolved Hide resolved
modules/statics/src/coins.ts Show resolved Hide resolved
modules/statics/src/coins.ts Outdated Show resolved Hide resolved
modules/statics/src/coins.ts Outdated Show resolved Hide resolved
@baltiyal
Copy link
Contributor Author

Some tokens present in ticket but not added:

JASMY POLYGON:OM BSC:BTT TRX:BTT WFLOW GT XAUT

please add these as well

I have not added these tokens because they already exist in BitgoJS.

@baltiyal baltiyal merged commit fa3eb06 into master Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkateshv1266 venkateshv1266 venkateshv1266 approved these changes

@MohammedRyaan786 MohammedRyaan786 Awaiting requested review from MohammedRyaan786

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baltiyal @venkateshv1266 @MohammedRyaan786