BTC 1582.scriptpubkey prefix #5140
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capitalization of the scriptPubKey was not consistent with the one used in bitcoin core[1]. Fix capitalization and make parsing case-insensitive. 1: https://github.com/bitcoin/bitcoin/blob/v28.0/src/rpc/blockchain.cpp#L657 Issue: BTC-1582
The extended address format includes both regular addresses and strings starting with 'scriptPubKey:'. This commit renames the function to isScriptRecipient to better reflect its purpose. Issue: BTC-1582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: fix scriptPubKey prefix
The capitalization of the scriptPubKey was not consistent with the one used in
bitcoin core[1].
Fix capitalization and make parsing case-insensitive.
1: https://github.com/bitcoin/bitcoin/blob/v28.0/src/rpc/blockchain.cpp#L657
Issue: BTC-1582
fix(abstract-utxo): rename isExtendedAddressFormat to isScriptRecipient
The extended address format includes both regular addresses and strings starting
with 'scriptPubKey:'. This commit renames the function to isScriptRecipient to
better reflect its purpose.
Issue: BTC-1582