Skip to content

Adding unfreeze and withdraw for tron unstaking #6013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Conversation

abhijit0943
Copy link
Contributor

@abhijit0943 abhijit0943 commented Apr 22, 2025

TICKET: SC-1670

Adding support for unfreeze and withdrawexpireunfreeze txns

@abhijit0943 abhijit0943 force-pushed the SC-1670 branch 5 times, most recently from 5ebf190 to 0ed67c2 Compare April 22, 2025 12:02
@abhijit0943 abhijit0943 changed the title Adding unfreeze for tron unstaking Adding unfreeze and withdraw for tron unstaking Apr 22, 2025
noel-bitgo

This comment was marked as resolved.

@abhijit0943 abhijit0943 requested a review from noel-bitgo April 29, 2025 09:37
Vijay-Jagannathan

This comment was marked as resolved.

@abhijit0943 abhijit0943 removed the request for review from noel-bitgo May 5, 2025 08:04
Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to other PR and address similar comments in this PR

/**
* Valid resource types for Tron freezing and unfreezing
*/
export enum TronResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be used in freeze PR as well

const withdrawValues = (rawData.contract[0] as WithdrawExpireUnfreezeContract).parameter.value;
output = {
address: withdrawValues.owner_address,
value: '0', // no value field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to understand, why this is 0 in StakingWithdraw type?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just set as a placeholder as we don't provide any explicit value for the amount to be withdrawn

Copy link
Contributor

@noel-bitgo noel-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test to build from raw?

@Vijay-Jagannathan
Copy link
Contributor

test to build from raw?

some of the test cases do build the txn and then do .from to build from raw and assert on whether they are same or not

@Vijay-Jagannathan Vijay-Jagannathan marked this pull request as ready for review May 22, 2025 18:36
@Vijay-Jagannathan Vijay-Jagannathan requested a review from a team as a code owner May 22, 2025 18:36
@noel-bitgo
Copy link
Contributor

test to build from raw?

some of the test cases do build the txn and then do .from to build from raw and assert on whether they are same or not

oh my bad, looks good

@Vijay-Jagannathan Vijay-Jagannathan merged commit 34da36c into master May 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants