-
Notifications
You must be signed in to change notification settings - Fork 296
Adding unfreeze and withdraw for tron unstaking #6013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5ebf190
to
0ed67c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to other PR and address similar comments in this PR
/** | ||
* Valid resource types for Tron freezing and unfreezing | ||
*/ | ||
export enum TronResource { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be used in freeze PR as well
const withdrawValues = (rawData.contract[0] as WithdrawExpireUnfreezeContract).parameter.value; | ||
output = { | ||
address: withdrawValues.owner_address, | ||
value: '0', // no value field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to understand, why this is 0 in StakingWithdraw type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just set as a placeholder as we don't provide any explicit value for the amount to be withdrawn
220d2ba
to
8c91851
Compare
8c91851
to
bf49450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test to build from raw?
some of the test cases do build the txn and then do .from to build from raw and assert on whether they are same or not |
oh my bad, looks good |
TICKET: SC-1670
Adding support for unfreeze and withdrawexpireunfreeze txns