-
Notifications
You must be signed in to change notification settings - Fork 300
Wp 5782/fix near token enablement validation #6958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wp 5782/fix near token enablement validation #6958
Conversation
3371efc to
b81a0d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes requested but you got a general first idea, good job! let me know if you need further clarification on any of the mentioned points @SimonVutovB
Thanks!
8d0fb13 to
fa835c7
Compare
|
@SimonVutovB for this issue that you're getting on the CI/CD steps, just rebase master since your dep versions are out of date:
|
fa835c7 to
cf059f2
Compare
cf059f2 to
6141074
Compare
e9cbf28 to
10c27f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a unit test to show sendTokenEnablements throws an error when you mock a response with a spoofed TxHex. Otherwise lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a test case showcasing sendAccountConsolidations fails when a spoofed txHex is returned in the response.
f4a41a4 to
3be12f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that shows a spoofed tx from platform will be rejected, similar to HBAR's?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll also request a review from the coin owners.
|
Removed myself from the reviewers, please add the |
04f2a6c to
703d629
Compare
703d629 to
7006cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think changes are getting there, I tested this locally and transactions are being verified but we need to write a more comprehensive unit test.
c28039b to
e3ad57d
Compare
e3ad57d to
2150024
Compare

Summary
Added token enablement validation and tests
Changes
verifyTransactionin near.ts of sdk-coin-near, validate the txHex is a valid token enablement transaction for the specified token and does not have additional transactions embedded.TICKET: WP-5782