refactor: migrated generateWallet to typed routes #7052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
16a0cd0 to
96dd8d5
Compare
danielzhao122
force-pushed
the
WP-5415-express-migrate-api-v2-coin-wallet-generate-to-typed-routes
branch
from
fb1254e to
678e891
Compare
zahin-mohammad
requested changes
Oct 15, 2025
Comment on lines
+16
to
+17
| /** If absent, BitGo uses the default wallet type for the asset */ | ||
| multisigType: multisigType, |
There was a problem hiding this comment.
The command and the codec here seem to conflict. The codec makes this a required field. The comment says this should be optional.
Comment on lines
+18
to
+19
| /** The type of wallet, defined by key management and signing protocols. 'hot' and 'cold' are both self-managed wallets. If absent, defaults to 'hot' */ | ||
| type: walletType, |
| /** Wallet label */ | ||
| label: t.string, | ||
| /** Enterprise id. This is required for Ethereum wallets since they can only be created as part of an enterprise */ | ||
| enterprise: t.string, |
There was a problem hiding this comment.
Enterprise is optional in GenerateWalletOptions
There was a problem hiding this comment.
I think this might actually be required, but to avoid introducing a breaking change for this change we should map the codec to what GenerateWalletOptions defines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added keychain codecs to a general codec file, as I assume that these codecs could be reused (but not sure if they will). refactored the UT that covered generateWallet to ensure that encoding and decoding works e2e.
TICKET: WP-5415