feat: added isWalletAddress implementation for canton #7410
Conversation
yes makes sense, I'll change the implementation |
ravibitgo
force-pushed
the
COIN-6323
branch
2 times, most recently
from
3da889c to
2268dba
Compare
There was a problem hiding this comment.
a better way to test this is to create two wallets with different key triples, create two addresses, and assert that isWalletAddress is true for the correct wallet and false for the other wallet
| const commonKeychain = extractCommonKeychain(keychains); | ||
| const MPC = await EDDSAMethods.getInitializedMpcInstance(); | ||
| const derivationPath = 'm/0'; | ||
| const derivedPublicKey = MPC.deriveUnhardened(commonKeychain, derivationPath).slice(0, 64); | ||
| const publicKeyBase64 = Buffer.from(derivedPublicKey, 'hex').toString('base64'); | ||
| const rootAddressFingerprint = utils.getAddressFromPublicKey(publicKeyBase64); | ||
| const rootAddress = `${rootAddressFingerprint.slice(0, 5)}::${rootAddressFingerprint}`; | ||
| return addressPart === rootAddress; |
There was a problem hiding this comment.
Please re-use the generic methods used for other ED coins.
async isWalletAddress(params: TssVerifyAddressOptions): Promise<boolean> {
return verifyEddsaTssWalletAddress(
params,
(address) => this.isValidAddress(address),
(publicKey) => this.getAddressFromPublicKey(publicKey)
);
}
you just need to change the implementation of the two call back functions.
There was a problem hiding this comment.
Hey @zahin-mohammad , canton is a memo based coin so I can't directly use this function. I was thinking of adding,
export async function verifyEddsaMemoBasedWalletAddress(
params: TssVerifyAddressOptions,
isValidAddress: (address: string) => boolean,
getAddressFromPublicKey: (publicKey: string) => string
): Promise {
const { keychains, address, index } = params;
const [addressPart, memoId] = address.split('?memoId=');
if (memoId && memoId !== index) {
throw new InvalidAddressError(invalid memoId: ${memoId});
}
if (!isValidAddress(addressPart)) {
throw new InvalidAddressError(invalid address: ${addressPart});
}
const commonKeychain = extractCommonKeychain(keychains);
const MPC = await EDDSAMethods.getInitializedMpcInstance();
const derivationPath = 'm/0';
const derivedPublicKey = MPC.deriveUnhardened(commonKeychain, derivationPath).slice(0, 64);
const expectedAddress = getAddressFromPublicKey(derivedPublicKey);
return addressPart === expectedAddress;
}
This method and use it when sdk-core is published. I'll create a ticket in backlog for this refactor, what do you think?
Ticket: COIN-6323