feat(sdk-coin-algo): verify consolidation transaction #7411
+507
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
force-pushed
the
WP-5729/validate-algo-consolidation
branch
from
9c050b7 to
91829d6
Compare
mohammadalfaiyazbitgo
changed the title
Implement verification to ensure consolidation transactions send funds to the wallet's base address (rootAddress). This prevents malicious transactions from redirecting consolidated funds to unauthorized addresses. Changes: - Add consolidationToBaseAddress verification in verifyTransaction method - Verify transaction recipient matches wallet rootAddress for both native (pay) and token (axfer) transactions - Test both positive (valid consolidation) and negative (malicious) cases The verification is triggered when params.verification.consolidationToBaseAddress is set to true, which happens automatically in sendAccountConsolidations. Ticket: WP-5729 TICKET: WP-5729
mohammadalfaiyazbitgo
force-pushed
the
WP-5729/validate-algo-consolidation
branch
from
91829d6 to
998b287
Compare
margueriteblair
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement verification to ensure consolidation transactions send funds to the wallet's base address (rootAddress). This prevents malicious transactions from redirecting consolidated funds to unauthorized addresses.
Changes:
The verification is triggered when params.verification.consolidationToBaseAddress is set to true, which happens automatically in sendAccountConsolidations.
TICKET: WP-5729