Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mail exploration #1198

Closed
wants to merge 4 commits into from
Closed

feat: Mail exploration #1198

wants to merge 4 commits into from

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Feb 14, 2022 •
edited
Loading

Purpose of PR:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a player
  • This will fix a bug

Preview results in my branch at the url:

B95B8A53-D944-40A3-B9E4-1022C82E7B44

@tchalvak tchalvak changed the title feat: Mail fixes feat: Mail exploration Feb 15, 2022
@tchalvak tchalvak mentioned this pull request Apr 20, 2022
Closed
@tchalvak tchalvak marked this pull request as draft July 19, 2023 14:48
@tchalvak
Copy link
Member Author

Rejecting this in favor of: #1530

@tchalvak tchalvak closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Critical medium risk Needs re-testing needs work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tchalvak