Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: actions check.php and basecheck.php separation, audit, static build, cachebust test #1381

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

feat: actions check.php and basecheck.php separation, audit, static build, cachebust test #1381

wants to merge 17 commits into from

Conversation

tchalvak
Copy link
Member

Purpose of PR:

Before

After

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

tchalvak and others added 16 commits January 12, 2023 01:25
@tchalvak
Add audit github action.
800d2d6
@tchalvak
Create static build process for index and intro pages.
cb3612c
@tchalvak
Still yarn install during audit.
9b5607b
@tchalvak
Unit test cachebust more permissively.
0bfdb45
@tchalvak
Test green if hash not added to file,
2b6e482 
as long as it generally contains the initial part of the path still.
@tchalvak
init-project is just an echo for now
b099111
@tchalvak
Update audit.yml
291df18
@tchalvak
Bump ratchet due to intro script being in www now.
cfcb16b
@tchalvak
Update build slightly, and run in php.yml workflow,
b928ba6 
make build in the php github action.
@tchalvak
Fix bad cachebust assertion.
a1b2f8e
@tchalvak
gitignore the static build html files.
3be7f6d
@tchalvak
Remove database connection check from build.
0a3cb05
@tchalvak
Split integration from file tests.
a865434
@deepsource-autofix @tchalvak
Format code with php-cs-fixer
a8653a8
@tchalvak
Update ratchets for new audit files.
a410afd
@deepsource-autofix
Format code with php-cs-fixer
fb866b3
@tchalvak tchalvak changed the title Feat/actions check.php and basecheck.php separation, audit, static build, cachebust test feat: actions check.php and basecheck.php separation, audit, static build, cachebust test Jan 12, 2023
@tchalvak tchalvak marked this pull request as draft July 19, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tchalvak