Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update live nginx conf for php8.2. #1531

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Update live nginx conf for php8.2. #1531

merged 1 commit into from
Sep 30, 2023

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Sep 25, 2023

Purpose of PR:

Have to consider the impact of this somewhat carefully, though the version should already be updated on live... ...unless something big was missed.

Edit: going to perform this merge as a rollback potential.


Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak changed the title Update live conf for php8.2. Update live nginx conf for php8.2. Sep 29, 2023
@tchalvak tchalvak requested a review from a team September 30, 2023 20:19
@tchalvak tchalvak self-assigned this Sep 30, 2023
@tchalvak tchalvak removed the request for review from a team September 30, 2023 20:19
@tchalvak tchalvak merged commit b7df735 into master Sep 30, 2023
1 check passed
@tchalvak tchalvak deleted the feat/config-ver branch September 30, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant