New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in dojo. #1541

Merged

tchalvak merged 1 commit into master from feat/dojo-typo-fix

Oct 1, 2023

Member

tchalvak commented Oct 1, 2023

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

Changing more than 20 files (much harder to review)
Changing more than 5 files (a bit harder to review)
Changes to critical code (login, dashboard, etc)
No comments on changed files
Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

I attached a screenshot of the changed part of the app working
I added tests
This feature is requested specifically by a user
This will fix a bug

Preview results in my branch at the url:

https://localhost:8765/someUrlHere


          Fix typo in dojo.

b2d431f

tchalvak enabled auto-merge

October 1, 2023 21:57

tchalvak merged commit c10010e into master

8 of 9 checks passed

tchalvak deleted the feat/dojo-typo-fix branch

October 1, 2023 21:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet