Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress tests for fight, npc, map, signup, stats #1563

Merged
merged 13 commits into from
Oct 7, 2023
Merged

Cypress tests for fight, npc, map, signup, stats #1563

merged 13 commits into from
Oct 7, 2023

Conversation

tchalvak
Copy link
Member

@tchalvak tchalvak commented Oct 6, 2023 •
edited
Loading

Purpose of PR:

Creates the test suites for the functional tests for stats, signup, skills, map, npc/fight/enemies/thief.

WIP on the CI integration for the cypress tests, but it'll happen eventually, costly tho they be.

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

tchalvak and others added 7 commits October 6, 2023 19:15
@tchalvak
Clarify workflow as being just the functional tests,
621a1d2 
and exit fail for now as a status code with npm run start,
which does not do as expected on the current test system...
@tchalvak
Update with recommended paralellized GA.
e8727a3
@tchalvak
Tests for fight, map, skills,
c96f5a0 
add egg item, modifications to try to improve npcs, especially that
tricksy thief.
@deepsource-autofix
style: format code with PHP CS Fixer
151fd62 
This commit fixes the style issues introduced in c96f5a0 according to the output
from PHP CS Fixer.

Details: #1563
@tchalvak
Change thief test boundaries.
6be303e
@tchalvak
Fix minor loop intensivity,
3a6bcc1 
probably a microoptimization, but static analysis picked it up.
@tchalvak
Allow direct attacks of npcs,
3b670b9 
without triggering a main iframe jump.
@tchalvak tchalvak changed the title Cypress action update Cypress tests for fight, npc, map, signup, stats Oct 7, 2023
@tchalvak tchalvak merged commit f491543 into master Oct 7, 2023
9 of 16 checks passed
@tchalvak tchalvak deleted the tests/skills-page branch October 7, 2023 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tchalvak