Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 3 updates, fix to avoid deprecated catchphrases.size() #1757

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tchalvak
Copy link
Member

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak tchalvak added the hold label May 31, 2024
@tchalvak
Copy link
Member Author

Awaiting other commit changes.

Copy link

cypress bot commented May 31, 2024

Passing run #456 ↗︎

0 14 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 2e26a7a into c526f2f...
Project: NinjaWars Functional Testing Commit: 85dfe6e28d ℹ️
Status: Passed Duration: 02:15 💡
Started: May 31, 2024 10:25 PM Ended: May 31, 2024 10:28 PM

Review all test suite changes for PR #1757 ↗︎

@tchalvak tchalvak changed the title Fix for catchphrases.size() that no longer exists. jQuery 3 updates, fix to avoid deprecated catchphrases.size() May 31, 2024
@tchalvak tchalvak marked this pull request as draft June 1, 2024 22:19
@tchalvak
Copy link
Member Author

tchalvak commented Jun 1, 2024

Check on the functionality of the enemies page and dishing and bath house, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant