Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide class Filter toSimple with polyfill #1758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide class Filter toSimple with polyfill #1758

wants to merge 2 commits into from

Conversation

tchalvak
Copy link
Member

For use with filtering down to low simple alphanumerics,

getting rid of ugly html-likes, and similar.

Purpose of PR:

Before

After

For Non-Hotfixes:

Attached Screenshot of my change:

Things that make review take longer:

(remove lines that do not apply to this PR)

  • Changing more than 20 files (much harder to review)
  • Changing more than 5 files (a bit harder to review)
  • Changes to critical code (login, dashboard, etc)
  • No comments on changed files
  • Tests do not pass (will get pushed back)

Things that make review faster and easier:

(check box with an x where it applies)

  • I attached a screenshot of the changed part of the app working
  • I added tests
  • This feature is requested specifically by a user
  • This will fix a bug

Preview results in my branch at the url:

@tchalvak
Provide filter to simple polyfill
ae47891 
For use with filtering down to low simple alphanumerics,

getting rid of ugly html-likes, and similar.
@tchalvak tchalvak changed the title Provide filter to simple polyfill Provide class Filter toSimple with polyfill May 31, 2024
@deepsource-autofix
style: format code with PHP CS Fixer
04fbaf7 
This commit fixes the style issues introduced in ae47891 according to the output
from PHP CS Fixer.

Details: #1758
@cypress Cypress
Copy link

cypress bot commented May 31, 2024 •
edited
Loading

Passing run #458 ↗︎

0 14 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 04fbaf7 into c526f2f...
Project: NinjaWars Functional Testing Commit: 3872e1ee89 ℹ️
Status: Passed Duration: 02:05 💡
Started: May 31, 2024 10:48 PM Ended: May 31, 2024 10:50 PM

Review all test suite changes for PR #1758 ↗︎

@tchalvak tchalvak enabled auto-merge May 31, 2024 22:51
@tchalvak
Copy link
Member Author

tchalvak commented Jun 1, 2024

Need to pull the test updates over as well.

@tchalvak tchalvak added the wip label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tchalvak