Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dark mode and light mode theme issues in footer, About Us segment, InputModal, Navbar and Login/Signup components; added PropTypes validation in About Us page and Discussions to prevent bugs, footer. #103

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

anothercoder-nik
Copy link
Contributor

@anothercoder-nik anothercoder-nik commented Oct 13, 2024

Pull Request Description

Title: Fixes for Dark Mode and Light Mode Themes & Added PropTypes Validation

I’ve made some updates to improve our app’s appearance and stability. Here’s what I worked on:

  1. Theme Improvements:

    • I fixed the dark mode and light mode themes in several areas, including:
      • The footer
      • The About Us section
      • The Navbar
      • The Login and Signup components
      • InputModal
    • Now, everything should look great whether you're in dark mode or light mode!
  2. PropTypes Validation:

    • I added PropTypes validation to the About Us page and the Discussions component. This should help catch any bugs related to incorrect props being passed around, making our code more robust.

Testing:

  • I tested everything to ensure that the theme toggle works seamlessly across the affected components.
  • The PropTypes validation is in place, so we should see fewer runtime errors moving forward.

Why This Matters:

  • With these changes, our app will provide a consistent and enjoyable experience for users.
  • Plus, the added validation helps us write better code and catch potential issues early on.

Below are the fixes-
Signup page

fixed_signup.mp4

About Us

fixed_aboutus.mp4

Nav Bar login|Signup button

fixed_login.mp4

InputModal Now Woking fine in Dark/Light Mode

dark

light

Let me know if you have any questions or feedback!

…nt, InputModal, Navbar and Login/Signup components; added PropTypes validation in About Us page and Discussions to prevent bugs, footer.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @anothercoder-nik for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

@Anuj3553
Copy link
Collaborator

Hyy @anothercoder-nik, There are so many conflicts. Can you pull again the code and apply your updated features.

image

@anothercoder-nik
Copy link
Contributor Author

anothercoder-nik commented Oct 14, 2024

Sure I will check again just now and will update it by today.

@Anuj3553
Copy link
Collaborator

Sure I will check again just now and will update it by today.

Okk @anothercoder-nik

@anothercoder-nik
Copy link
Contributor Author

hey @Anuj3553 , I cleared all the conflicts , its like someone else fixed some code which I did which got committed before me, but now I resolved it , kindly check soon please. Thanks for giving the opportunity to me.

@anothercoder-nik
Copy link
Contributor Author

Current Status

conflict_resolved

@Anuj3553 Anuj3553 self-requested a review October 15, 2024 14:10
@Anuj3553 Anuj3553 added gssoc-ext Extended contribution for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task hacktoberfest Open-source contribution during October for GSSoC labels Oct 15, 2024
@Anuj3553
Copy link
Collaborator

hey @Anuj3553 , I cleared all the conflicts , its like someone else fixed some code which I did which got committed before me, but now I resolved it , kindly check soon please. Thanks for giving the opportunity to me.

Yes i did changes because many them are facing that issue. Well done @anothercoder-nik.

@Anuj3553 Anuj3553 merged commit 8d07794 into Bitbox-Connect:main Oct 15, 2024
1 check passed
@anothercoder-nik
Copy link
Contributor Author

Thanks @Anuj3553 for giving the chance to let me contribute, Good Wishes to you!

@Anuj3553
Copy link
Collaborator

Thanks @Anuj3553 for giving the chance to let me contribute, Good Wishes to you!

Thank you so much for your kind words and for contributing to the project. Wishing you all the best in your future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Extended contribution for GSSoC hacktoberfest Open-source contribution during October for GSSoC hacktoberfest-accepted Eligible contribution for Hacktoberfest rewards level1 Beginner-level contribution or task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants