-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed dark mode and light mode theme issues in footer, About Us segment, InputModal, Navbar and Login/Signup components; added PropTypes validation in About Us page and Discussions to prevent bugs, footer. #103
Conversation
…nt, InputModal, Navbar and Login/Signup components; added PropTypes validation in About Us page and Discussions to prevent bugs, footer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you @anothercoder-nik for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better
Hyy @anothercoder-nik, There are so many conflicts. Can you pull again the code and apply your updated features. |
Sure I will check again just now and will update it by today. |
|
Signed-off-by: Nik-_- <[email protected]>
hey @Anuj3553 , I cleared all the conflicts , its like someone else fixed some code which I did which got committed before me, but now I resolved it , kindly check soon please. Thanks for giving the opportunity to me. |
Yes i did changes because many them are facing that issue. Well done @anothercoder-nik. |
Thanks @Anuj3553 for giving the chance to let me contribute, Good Wishes to you! |
Thank you so much for your kind words and for contributing to the project. Wishing you all the best in your future. |
Pull Request Description
Title: Fixes for Dark Mode and Light Mode Themes & Added PropTypes Validation
I’ve made some updates to improve our app’s appearance and stability. Here’s what I worked on:
Theme Improvements:
PropTypes Validation:
Testing:
Why This Matters:
Below are the fixes-
Signup page
fixed_signup.mp4
About Us
fixed_aboutus.mp4
Nav Bar login|Signup button
fixed_login.mp4
InputModal Now Woking fine in Dark/Light Mode
Let me know if you have any questions or feedback!