Merge pull request #155 from Bitcoin-com/ct-fix-integration-tests

Ct fix integration tests

package.json

@@ -78,7 +78,7 @@
     "node-mocks-http": "^1.7.0",
     "nyc": "^14.1.1",
     "prettier": "^1.14.2",
-    "semantic-release": "^15.13.3",
+    "semantic-release": "^15.13.31",
     "sinon": "^4.5.0",
     "source-map-support": "^0.5.12",
     "ts-node": "^8.1.0",

test/integration/address.js

@@ -130,7 +130,8 @@ describe(`#address`, () => {
         "legacyAddress",
         "cashAddress",
         "scriptPubKey",
-        "slpAddress"
+        "slpAddress",
+        "asm"
       ])
       assert.isArray(result.utxos)
       assert.hasAnyKeys(result.utxos[0], [
@@ -158,7 +159,8 @@ describe(`#address`, () => {
         "legacyAddress",
         "cashAddress",
         "scriptPubKey",
-        "slpAddress"
+        "slpAddress",
+        "asm"
       ])
       assert.isArray(result[0].utxos)
       assert.hasAnyKeys(result[0].utxos[0], [
@@ -215,7 +217,8 @@ describe(`#address`, () => {
         "legacyAddress",
         "cashAddress",
         "scriptPubKey",
-        "slpAddress"
+        "slpAddress",
+        "asm"
       ])
       assert.isArray(result.utxos)
     })
@@ -235,7 +238,8 @@ describe(`#address`, () => {
         "legacyAddress",
         "cashAddress",
         "scriptPubKey",
-        "slpAddress"
+        "slpAddress",
+        "asm"
       ])
       assert.isArray(result[0].utxos)
     })

test/integration/other/README.md

@@ -0,0 +1,8 @@
+# Other Integration Tests
+
+This directory holds stand-alone integration tests that should not be part of
+the integration test suite.
+
+An example of a test that fits this criteria are rate limit tests. Rate limit
+tests are complex, require a solid internet connection, and can easily disrupt
+other tests. For those reasons, it is better to run them on their own. 

test/integration/transaction.js

@@ -87,7 +87,7 @@ describe(`#Transaction`, () => {
         // console.log(`result: ${util.inspect(result)}`)
         assert.equal(false, false, "Unexpected result!")
       } catch (err) {
-        console.log(`err: ${util.inspect(err)}`)
+        // console.log(`err: ${util.inspect(err)}`)
 
         assert.hasAnyKeys(err, ["error"])
         assert.include(err.error, "Array too large")

test/integration/util.js

@@ -44,7 +44,7 @@ describe(`#util`, () => {
       assert.equal(result.isvalid, false)
     })
 
-    it(`should return validate valid address`, async () => {
+    it(`should return a valid address`, async () => {
       const address = `bitcoincash:qp4k8fjtgunhdr7yq30ha4peuwupzan2vcnwrmpy0z`
 
       const result = await bitbox.Util.validateAddress(address)
@@ -54,8 +54,6 @@ describe(`#util`, () => {
         "isvalid",
         "address",
         "scriptPubKey",
-        "ismine",
-        "iswatchonly",
         "isscript"
       ])
       assert.equal(result.isvalid, true)
@@ -75,8 +73,6 @@ describe(`#util`, () => {
         "isvalid",
         "address",
         "scriptPubKey",
-        "ismine",
-        "iswatchonly",
         "isscript"
       ])
     })