Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AoF formatting #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Greg-Griffith
Copy link

section 2.5 formatting adjusted so 2.5 now starts on its own line

@sickpig
Copy link
Collaborator

sickpig commented May 30, 2019

@Greg-Griffith
thanks for fixing this!

I noticed that you regenerate the PDF from scratch and I like the new formatting more than the old one by the way.

I'm just wondering how we could manage to review this kind of PR which are changing binaries in an efficient way.

So far the only way that comes to my mind is to extract text from AoF pdf versions and comparing them somehow. Do you have any better idea?

Having said that I skimmed the new AoF version and this are a series of feedback that goes beyond the scope of this PR but I think it's worth sharing regardless:

  • I'd use bold style for the title on the first page and maybe also a slightly bigger font.

  • Articles item list has different formatting, art 1 and 4 are formatted differently from 2 and 3. I'd say we could use the same formatting style.

@Greg-Griffith
Copy link
Author

Greg-Griffith commented May 30, 2019

@sickpig I actually did not notice that resulted in different formatting. I got a hold of the original word doc and re-exported it to pdf without actually looking at the pdf except to check that the spacing for that one line was fixed.

Looking at it now, i think the different formatting between 1,4 and 2,3 are due to 2 and 3 not having section titles where as 1 and 4 do. Also just noticed that the last paragraph (the actual agreement) is currently in bold on the website but is not in my re-export.

I will adjust the title of this PR and go back through my re-export to make formatting consistent

@Greg-Griffith Greg-Griffith changed the title Adjust Articles section 2.5 formatting Adjust AoF formatting May 30, 2019
@sickpig
Copy link
Collaborator

sickpig commented Jul 16, 2019

@gandrewstone @AndrewClifford could you please have a look at this PR. We need to make sure that the formatting improved while at the same time the actual content didn't get modified inadvertently.

I wonder if we could move the sys to have a, let say, markdown version of the article that we use as a source and that we convert to a pdf at run-time when needed.

This would make this kind of review a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants