Update scroll limit message for non-logged-in users #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihomp
requested changes
Apr 22, 2025
There was a problem hiding this comment.
- That component is used on many pages; we shouldn't change how it behaves there. We need to change the message ONLY for the two pages listed in the ticket.
Reasons: - Some pages don't have search parameters ,so that message wouldn't make sense.
- Some pages are not related to NFTs, like on AMM pool pages. So that wouldn't make sense there, either.
|
hi @ihomp |
ihomp
requested changes
Apr 24, 2025
|
It would also be good to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Add text to NFT Explorer/NFT Sales pages
Requrements
Instead of "Loading more data is available to logged-in Bithomp Pro subscribers.": Use different filter options or select other search parameters to explore more NFTs that match your interests. Log in to Bithomp Pro to enable infinite scroll and access all existing results!
Implemented
The text was added/updated only on these pages:
https://bithomp.com/en/nft-explorer
https://bithomp.com/en/nft-sales