Add connect wallet page #350
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A separate page instead of a pop-up? We just need to return the user to the same page after the login. We need to think on UI though.. and fix errors like "saveAddressData is not a function" |
|
we have this screen Basically, instead of having a list of wallets in the dropdown "Sign-in", we can have a "Connect a wallet" that will open that popup. |
|
Essentially the idea is to combine the wallet connect and login to bithomp-pro.. so, each bithomp-pro can have several verified crypto addresses, so user would be able to login by both: email and with a wallet, also user can login with email and choose verified address (instead of loging in with address). we have already verification functions in place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting with moving the
connect your walletflow to a separate page. Now, walletconnect and other related logic is embedded directly into each page.This should help with: