Batch transactions - Add support #621
Conversation
|
We need to show all transactions data that is in the batch. @Anna15170221 can you take a look? please share transactions links that are used for tests |
|
@ihomp new examples provided by Ildar |
|
@ihomp |
|
@Anna15170221 please review again |
|
@ihomp |
Yes, but I think it will only be visible in production (mainnet/staging) - we can test with "staging" instead of "devnet" - than it should show. |
| import Link from 'next/link' | ||
|
|
||
| // Component to display transaction flags with tooltips | ||
| const TransactionFlags = ({ flags }) => { |
There was a problem hiding this comment.
we have the functionn in utils showFlags - please reuse it
|
@ihomp |
| {outcome?.parentBatchID && ( | ||
| <tr> | ||
| <TData>Parent batch ID</TData> | ||
| <TData>{addressUsernameOrServiceLink(outcome, 'parentBatchID', { short: true, url: '/tx/' })}</TData> |
There was a problem hiding this comment.
The component is for addresses and usernames, but the link is for transactions?
so it's rather a wrong component or a wrong link or a wrong data
| <tr> | ||
| <TData>Initiated by</TData> | ||
| <TData> | ||
| <AddressWithIconFilled data={specification.source} name="address" /> |
There was a problem hiding this comment.
that seems used wrong
it should be object and then the name of the address field
<AddressWithIconFilled data={specification} name="source" />
There was a problem hiding this comment.
make sure there is specification.sourceDetails - otherwise contact Ildar to add it.
| <tr> | ||
| <TData style={{ paddingLeft: '30px' }}>ID</TData> | ||
| <TData> | ||
| <Link href={`/tx/${transaction.id}`}> |
There was a problem hiding this comment.
Please reuse LinkTx from utils/links
| { | ||
| maxAmount && | ||
| <tr> | ||
| <TData style={{ paddingLeft: '30px' }}>Max Amount</TData> |
There was a problem hiding this comment.
Why do all of them have paddingLeft: 30?
|
@ihomp |
3 participants
Issue
Add support of batch txs
Now, I display the main datas.
If you share your specific requirements, I’ll take care of the implementation.