Create 23.cpp #54
Create 23.cpp #54
Conversation
|
Use stacks. |
Will it reduce time complexity?How will it make the solution better please elaborate. |
|
You ever done Infix to Post-fix? We use stacks because they are helpful in expression evaluation. This solution works because there isn't any expression within the braces. But if you use stacks, even if there are any expressions between the braces, you can just count the number of remaining braces after the matching braces have been popped. TL;DR: Solution works, expected solution to use stacks. Some comments in the source code would have been better. 🙂 |
|
Never used stacks before,i am noobie.Going to google some words now :).
Comment addition noted for next time.
…On Thu, 17 Oct, 2019, 12:08 AM MaDDogx, ***@***.***> wrote:
You ever done Infix to Post-fix? We use stacks because they are helpful in
expression evaluation. This solution works because there isn't any
expression within the braces.
But if you use stacks, even if there are any expressions between the
braces, you can just count the number of remaining braces after the
matching braces have been popped.
TL;DR:
Solution works, expected solution to use stacks.
Some comments in the source code would have been better. 🙂
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54?email_source=notifications&email_token=AEJ2QZV5ML5J6E2DUD7GBXTQO5NUDA5CNFSM4JBO4TP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBNQNZQ#issuecomment-542836454>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJ2QZXZZEO7IZEALV4NKMTQO5NUDANCNFSM4JBO4TPQ>
.
|
23.cpp
Outdated
| int cases,cases1; | ||
| cin>>cases; | ||
| cases1=cases; | ||
| int ar[cases]; |
There was a problem hiding this comment.
Don't do this for printing the output.
23.cpp
Outdated
| flag+=2; | ||
| i++; | ||
| } | ||
| ar[cases-cases1]=leng-flag; |
There was a problem hiding this comment.
Just print the output using cout.
int diff = length - flag; // flag? there could have been a better word
cout << diff << "\n;
23.cpp
Outdated
| for(int i=0;i<cases;i++) | ||
| cout<<ar[i]<<endl; |
There was a problem hiding this comment.
Remove this, it's not needed.
No description provided.