Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNG-4219 Builders can be reusable #199

Merged
merged 4 commits into from
Nov 9, 2023
Merged

JNG-4219 Builders can be reusable #199

merged 4 commits into from
Nov 9, 2023

Conversation

gaborflorian
Copy link
Contributor

@gaborflorian gaborflorian commented Nov 7, 2023 •
edited by github-actions bot
Loading

Sub-taskJNG-4219 Make builder methods results immutable. Means builders can be reusable. (the with method is a copy)

JNG-4219 Builders can be reusable

@gaborflorian gaborflorian marked this pull request as ready for review November 7, 2023 16:23
@gaborflorian gaborflorian merged commit 26f56f2 into develop Nov 9, 2023
3 checks passed
@gaborflorian gaborflorian deleted the feature/JNG-4219_Builders_can_be_reusable branch November 9, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madmat8 Madmat8 Madmat8 approved these changes

@robertcsakany robertcsakany robertcsakany approved these changes

@bencegelei bencegelei Awaiting requested review from bencegelei

@noherczeg noherczeg Awaiting requested review from noherczeg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaborflorian @robertcsakany @Madmat8