Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNG-5745 fix row actions with mapped inputs #409

Merged
merged 4 commits into from
May 31, 2024

Conversation

noherczeg
Copy link
Contributor

@noherczeg noherczeg commented May 31, 2024

BugJNG-5745 Calling operation with mapped input in a table causes error

Copy link

coderabbitai bot commented May 31, 2024

Warning

Rate limit exceeded

@noherczeg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 34 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between f533b22 and 07a33f9.

Walkthrough

The recent updates to the judo-ui-react module introduce several improvements and refinements. Key changes include conditional checks for action parameters, replacement of label checking methods, and renaming/refactoring of icon and label-related functions. These updates enhance the logic for handling visual elements and action definitions, ensuring more precise and context-aware behavior across various components and templates.

Changes

File Path Change Summary
.../UiActionsHelper.java Added a conditional check for targetType in getSelectorOpenActionParameters.
.../UiI18NHelper.java Replaced flexHasLabel with elementHasLabel in label checking logic.
.../UiPageContainerHelper.java Modified cardHasHeaderContent to use elementHasIconOrLabel instead of flexHasIconOrLabel.
.../UiWidgetHelper.java Renamed flexHasIconOrLabel to elementHasIconOrLabel and refactored related logic, introduced elementHasIcon and elementHasLabel functions. Added displayTableHeading function.
.../divider.hbs Updated logic for checking child elements to use elementHasIconOrLabel, elementHasIcon, and elementHasLabel.
.../flex.hbs Renamed functions for icon and label checks to elementHasIconOrLabel, elementHasIcon, and elementHasLabel.
.../table.hbs Reorganized layout, added conditional rendering for table headings, and introduced MdiIcon and Typography components.

Poem

Amidst the code where changes flow,
Labels and icons now in tow,
With elementHas they find their way,
To brighten up the UI's day.
Conditional checks, so smart and neat,
Make our app a joy to greet.
Hooray for updates, smooth and bright,
The code now shines with newfound light! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (1)
judo-ui-react/src/main/resources/actor/src/pages/actions/OpenOperationInputSelectorAction.fragment.hbs (1)

1-1: Add documentation for the new target parameter.

Consider adding a comment above the function to explain the conditions under which the target parameter should be used and its expected type. This will help other developers understand the changes and the function's usage more quickly.

@noherczeg noherczeg merged commit 589fe43 into develop May 31, 2024
3 checks passed
@noherczeg noherczeg deleted the bugfix/JNG-5745-row-actions-with-mapped-input branch May 31, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants