JNG-5767 handle missing single association

[noherczeg]

JNG-5767 Optional association with table representation allows view operation and causes runtime exception in case field is empty

[coderabbitai]

Walkthrough

The recent changes primarily focus on modifying return types in various Java and TypeScript files within the judo-ui-react project. These modifications ensure that certain methods now return types that include null for specific conditions. Additionally, the pom.xml file was updated to incorporate a new version of the judo-ui-typescript-rest dependency, addressing a bug fix.

Changes

File Path	Change Summary
judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiActionsHelper.java	Modified return types of methods to include `"
.../src/main/resources/actor/src/components/widgets/AssociationButton.tsx.hbs	Updated fetchCall function return type to `Promise<JudoRestResponse<JudoIdentifiable
.../src/main/resources/actor/src/pages/actions/PreFetchAction.fragment.hbs	Changed return type of an async function to `JudoRestResponse<{{ classDataName action.actionDefinition.targetType 'Stored' }}
.../src/main/resources/actor/src/pages/actions/RefreshAction.fragment.hbs	Modified return type of a function to include null for {{ classDataName action.targetDataElement.target 'Stored' }} based on conditions.
pom.xml	Updated judo-ui-typescript-rest dependency version to 1.0.0.20240612_165732_227581db_bugfix_JNG_5767_handle_missing_single_association.

Poem

In the code where changes bloom,
Return types now make room,
For null in their embrace,
Ensuring a safer place.
Dependencies updated, bugs take flight,
A cleaner codebase, shining bright.
🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ad6d7b7 and 212e93e.

Files selected for processing (5)

• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiActionsHelper.java (2 hunks)
• judo-ui-react/src/main/resources/actor/src/components/widgets/AssociationButton.tsx.hbs (3 hunks)
• judo-ui-react/src/main/resources/actor/src/pages/actions/PreFetchAction.fragment.hbs (1 hunks)
• judo-ui-react/src/main/resources/actor/src/pages/actions/RefreshAction.fragment.hbs (1 hunks)
• pom.xml (1 hunks)

Additional comments not posted (5)

judo-ui-react/src/main/resources/actor/src/pages/actions/PreFetchAction.fragment.hbs (1)

1-1: The update to include | null in the return type is a good practice for handling potential null values, enhancing type safety.

judo-ui-react/src/main/resources/actor/src/components/widgets/AssociationButton.tsx.hbs (1)

19-19: The updates to fetchCall and the useState hook for data to handle nullable types are well-aligned with the PR's objectives to enhance type safety.

Also applies to: 34-34

judo-ui-react/src/main/resources/actor/src/pages/actions/RefreshAction.fragment.hbs (1)

2-2: The update to include | null in the return type is consistent with the PR's objectives to handle nullable types, enhancing type safety.

judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiActionsHelper.java (1)

102-102: The updates to the return types of getContainerOwnActionReturnType and linkActionDefinitionResponseType to include | null are well-aligned with the PR's objectives to enhance type safety by handling nullable types.

Also applies to: 210-210

pom.xml (1)

60-60: Updated version of judo-ui-typescript-rest to 1.0.0.20240612_165732_227581db_bugfix_JNG_5767_handle_missing_single_association looks appropriate for the bug fix JNG-5767.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.