JNG-5504 modelled table actions

[noherczeg]

JNG-5504 Implement in UI + transformations

[coderabbitai]

Walkthrough

The changes span across multiple files focusing on enhancing import handling, modifying logic for action definitions, and incorporating new features for UI elements such as confirmation dialogs and input form call operations. Methods were added to manage new conditions and workflows, improvements were made for error handling and bulk operations, and new comments for documentation purposes. Additionally, updates were made to test scripts and action templates.

Changes

Files/Paths	Change Summary
judo-ui-react/src/main/java/.../UiActionsHelper.java	Refactored imports, updated getContainerOwnActionDefinitions, and added new methods.
judo-ui-react/src/main/java/.../UiI18NHelper.java, UiPageContainerHelper.java, UiTableHelper.java	Introduced logic for translations, modified suffix determination, and refactored helper functions.
judo-ui-react/src/main/resources/actor/...	Added comments, updated logic for toolbar actions, dialogs, types handling, action fragments, etc.
update-test-models.sh	Included a file copy command for a model file related to RelationTest in a test script.

Poem

In the coding meadow, bunnies hop and leap,
They fix imports and helper classes so neat.
Dialogs confirmed with a warm bunny smile,
Refactoring methods makes it all worthwhile.
Let the bulk delete be simple and light,
Hopping through code, making it right! 🐰✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 95b228d and 6bc45a9.

Files selected for processing (1)

• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 8

Outside diff range and nitpick comments (5)

judo-ui-react/src/main/resources/actor/src/pages/actions/PreFetchAction.fragment.hbs (1)

Line range hint 2-5:
Consider adding error handling for the data fetching call.

Currently, there is no error handling for the data fetching call. This can lead to unhandled exceptions if the fetch operation fails.

const {{ simpleActionDefinitionName action.actionDefinition }} = async (): Promise<JudoRestResponse<{{ classDataName action.actionDefinition.targetType 'Stored' }} | null>> => {
-  return {{ getServiceImplForPage page }}.get{{ firstToUpper action.targetDataElement.name }}({{# if (pageHasSignedId page) }}{{# if page.openInDialog }}data{{ else }}{ __signedIdentifier: signedIdentifier } as any{{/ if }}{{ else }}data{{/ if }}, {
+  try {
+    return await {{ getServiceImplForPage page }}.get{{ firstToUpper action.targetDataElement.name }}({{# if (pageHasSignedId page) }}{{# if page.openInDialog }}data{{ else }}{ __signedIdentifier: signedIdentifier } as any{{/ if }}{{ else }}data{{/ if }}, {
      _mask: '{}',
+    });
+  } catch (error) {
+    console.error('Error during data fetch:', error);
+    // Handle the error appropriately
+    return null;
+  }
};

judo-ui-react/src/main/resources/actor/src/pages/actions/BulkRemoveAction.fragment.hbs (1)

Line range hint 2-29:
LGTM! Consider refactoring for better readability.

The changes to the selectedRows parameter type are correct. However, the nested conditionals and complex logic could benefit from some refactoring for better readability and maintainability.

Consider breaking down the nested conditionals into smaller helper functions to improve readability.

judo-ui-react/src/main/resources/actor/src/pages/actions/RefreshAction.fragment.hbs (1)

Line range hint 2-64:
LGTM! Consider refactoring for better readability.

The changes to the queryCustomizer parameter type are correct. However, the nested conditionals and complex logic could benefit from some refactoring for better readability and maintainability.

Consider breaking down the nested conditionals into smaller helper functions to improve readability.

judo-ui-react/src/main/resources/actor/src/pages/actions/OpenPageAction.fragment.hbs (1)

Line range hint 2-60:
LGTM! Consider refactoring for better readability.

The changes to the target parameter type are correct. However, the nested conditionals and complex logic could benefit from some refactoring for better readability and maintainability.

Consider breaking down the nested conditionals into smaller helper functions to improve readability.

judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiI18NHelper.java (1)

140-140: Remove unnecessary blank line.

The added blank line is not required and can be removed to keep the code clean.