JNG-5822 customizable page buttons #436
Conversation
noherczeg
commented
Jul 8, 2024
•
noherczeg
commented
 JNG-5822 Customized button cannot be added to action container
|
noherczeg
requested review from
robertcsakany,
bencegelei,
gaborflorian and
Madmat8
WalkthroughThe recent updates introduce two new Maven plugins, Changes
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (4)
Files skipped from review as they are similar to previous changes (1)
Additional comments not posted (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 14
Outside diff range and nitpick comments (13)
judo-snapshot-checker-maven-plugin/src/main/java/hu/blackbelt/judo/snapshotcheker/SnapshotCheckerMojo.java (2)
52-56: Consider logging the source files being processed.Logging the source files being processed can help in debugging and understanding the flow of the method.
+ getLog().info("Processing source file: " + sourceFile.getPath());
58-60: Improve error message clarity.The error message can be improved to include more context, such as the source file path that does not exist.
- throw new MojoExecutionException("Source file does not exist: " + sourceFile.getPath()); + throw new MojoExecutionException("Source file does not exist: " + sourceFilePath.toString());judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/View/ViewGalaxyViewDialogContainer.tsx.snapshot (1)
78-78: Consider addingaria-labelfor accessibility.The
IconButtoncomponent should have anaria-labelfor better accessibility.- aria-label="close" + aria-label="Close dialog"judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/Form/ViewGalaxyFormDialogContainer.tsx.snapshot (1)
78-87: Consider addingaria-labelfor accessibility.The
IconButtoncomponent should have anaria-labelfor better accessibility.- aria-label="close" + aria-label="Close dialog"judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (1)
46-50: Consider adding type annotations foruseRef.Adding type annotations for
useRefcan improve type safety and readability.- const owner = useRef<any>(null); + const owner = useRef<SomeType>(null); // Replace `SomeType` with the actual typejudo-snapshot-checker-maven-plugin/LICENSE.txt (8)
47-47: Consider a shorter alternative to avoid wordiness.The phrase "in each case in order to" can be simplified to "to" for brevity.
- in each case in order to link to, bind by name, or subclass the Program + to link to, bind by name, or subclass the ProgramTools
LanguageTool
[style] ~47-~47: Consider a shorter alternative to avoid wordiness.
Context: ...iles of the Program solely in each case in order to link to, bind by name, or subclass the ...(IN_ORDER_TO_PREMIUM)
92-93: Possible missing article.The sentence "if a third party patent license is required to allow Recipient to Distribute the Program" is missing the article "a" before "third party."
- if a third party patent license is required to allow Recipient to Distribute the Program + if a third party patent license is required to allow a Recipient to Distribute the ProgramTools
LanguageTool
[uncategorized] ~92-~92: Possible missing article found.
Context: ...y patent license is required to allow Recipient to Distribute the Program, it is Reci...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~93-~93: Possible missing article found.
Context: ...ient to Distribute the Program, it is Recipient's responsibility to acquire that licens...(AI_HYDRA_LEO_MISSING_THE)
114-114: Consider replacing this phrase with the adverb "reasonably" to avoid wordiness.The phrase "in a reasonable manner" can be simplified to "reasonably."
- in a reasonable manner on or through a medium customarily used for software exchange + reasonably on or through a medium customarily used for software exchangeTools
LanguageTool
[style] ~114-~114: Consider replacing this phrase with the adverb “reasonably” to avoid wordiness.
Context: ...d informs Recipients how to obtain it in a reasonable manner on or through a medium customarily us...(IN_A_X_MANNER)
118-118: Consider using 'different from' instead of 'different than'.The phrase "different than" is often considered colloquial. "Different from" is more formal.
- the Contributor may Distribute the Program under a license different than this Agreement + the Contributor may Distribute the Program under a license different from this AgreementTools
LanguageTool
[style] ~118-~118: Did you mean ‘different from’? ‘Different than’ is often considered colloquial style.
Context: ...the Program under a license different than this Agreement, provided that such lice...(DIFFERENT_THAN)
156-156: Consider a shorter alternative to avoid wordiness.The phrase "with respect to" can be simplified to "for."
- may accept certain responsibilities with respect to end users, business partners and the like + may accept certain responsibilities for end users, business partners and the likeTools
LanguageTool
[style] ~156-~156: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...are may accept certain responsibilities with respect to end users, business partners and the li...(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
171-171: Consider a shorter alternative to avoid wordiness.The phrase "in order to" can be simplified to "to."
- In order to qualify, an Indemnified Contributor must + To qualify, an Indemnified Contributor mustTools
LanguageTool
[style] ~171-~171: Consider a shorter alternative to avoid wordiness.
Context: ...ged intellectual property infringement. In order to qualify, an Indemnified Contributor mus...(IN_ORDER_TO_PREMIUM)
240-240: Consider a shorter alternative to avoid wordiness.The phrase "in order to" can be simplified to "to."
- but in order to avoid inconsistency the Agreement is copyrighted + but to avoid inconsistency the Agreement is copyrightedTools
LanguageTool
[style] ~240-~240: Consider a shorter alternative to avoid wordiness.
Context: ...istribute copies of this Agreement, but in order to avoid inconsistency the Agreement is co...(IN_ORDER_TO_PREMIUM)
250-250: Possible missing article.The sentence "after a new version of the Agreement is published, Contributor may elect to Distribute the Program" is missing the article "the" before "Contributor."
- after a new version of the Agreement is published, Contributor may elect to Distribute the Program + after a new version of the Agreement is published, the Contributor may elect to Distribute the ProgramTools
LanguageTool
[uncategorized] ~250-~250: Possible missing article found.
Context: ... version of the Agreement is published, Contributor may elect to Distribute the Program (in...(AI_HYDRA_LEO_MISSING_THE)
...checker-maven-plugin/src/main/java/hu/blackbelt/judo/snapshotcheker/SnapshotCheckerMojo.java
Outdated
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/View/ViewGalaxyViewDialogContainer.tsx.snapshot
Show resolved
Hide resolved
...urces/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot
Show resolved
Hide resolved
...checker-maven-plugin/src/main/java/hu/blackbelt/judo/snapshotcheker/SnapshotCheckerMojo.java
Outdated
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/View/ViewGalaxyViewDialogContainer.tsx.snapshot
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/View/ViewGalaxyViewDialogContainer.tsx.snapshot
Show resolved
Hide resolved
judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPandinoHelper.java
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/Form/ViewGalaxyFormDialogContainer.tsx.snapshot
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/Form/ViewGalaxyFormDialogContainer.tsx.snapshot
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/Form/ViewGalaxyFormDialogContainer.tsx.snapshot
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 3
Outside diff range and nitpick comments (1)
judo-diff-checker-maven-plugin/LICENSE.txt (1)
1-277: Correct minor language issues.There are minor language issues, such as missing articles and wordiness, that can be improved for better readability.
- Contributor disclaims any liability to Recipient for claims brought by any other entity based on infringement of intellectual property rights or otherwise. + The Contributor disclaims any liability to the Recipient for claims brought by any other entity based on infringement of intellectual property rights or otherwise. - If a third party patent license is required to allow Recipient to Distribute the Program, it is Recipient's responsibility to acquire that license before distributing the Program. + If a third-party patent license is required to allow the Recipient to Distribute the Program, it is the Recipient's responsibility to acquire that license before distributing the Program. - the Contributor may Distribute the Program under a license different than this Agreement, provided that such license: + the Contributor may Distribute the Program under a license different from this Agreement, provided that such license:Tools
LanguageTool
[style] ~47-~47: Consider a shorter alternative to avoid wordiness.
Context: ...iles of the Program solely in each case in order to link to, bind by name, or subclass the ...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~86-~86: Possible missing article found.
Context: ... Contributor disclaims any liability to Recipient for claims brought by any other entit...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~92-~92: Possible missing article found.
Context: ...y patent license is required to allow Recipient to Distribute the Program, it is Reci...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~93-~93: Possible missing article found.
Context: ...ient to Distribute the Program, it is Recipient's responsibility to acquire that licens...(AI_HYDRA_LEO_MISSING_THE)
[style] ~114-~114: Consider replacing this phrase with the adverb “reasonably” to avoid wordiness.
Context: ...d informs Recipients how to obtain it in a reasonable manner on or through a medium customarily us...(IN_A_X_MANNER)
[style] ~118-~118: Did you mean ‘different from’? ‘Different than’ is often considered colloquial style.
Context: ...the Program under a license different than this Agreement, provided that such lice...(DIFFERENT_THAN)
[style] ~156-~156: ‘with respect to’ might be wordy. Consider a shorter alternative.
Context: ...are may accept certain responsibilities with respect to end users, business partners and the li...(EN_WORDINESS_PREMIUM_WITH_RESPECT_TO)
[style] ~171-~171: Consider a shorter alternative to avoid wordiness.
Context: ...ged intellectual property infringement. In order to qualify, an Indemnified Contributor mus...(IN_ORDER_TO_PREMIUM)
[style] ~240-~240: Consider a shorter alternative to avoid wordiness.
Context: ...istribute copies of this Agreement, but in order to avoid inconsistency the Agreement is co...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~240-~240: Possible missing comma found.
Context: ...f this Agreement, but in order to avoid inconsistency the Agreement is copyrighted and may on...(AI_HYDRA_LEO_MISSING_COMMA)
judo-diff-checker-maven-plugin/src/main/java/hu/blackbelt/judo/diffchecker/DiffCheckerMojo.java
Show resolved
Hide resolved
...ts/frontend-react/src/containers/View/Galaxy/View/ViewGalaxyViewDialogContainer.tsx.snapshot
Show resolved
Hide resolved
