JNG-5826 Fixing operation name

[robertcsakany]

JNG-5826 Add suffix for all FormOperations to be able to reuse the FormOperation given name

JNG-5826 Fixing operation name

[coderabbitai]

Walkthrough

The recent changes primarily involve updating action identifiers within comments in snapshot files, adjusting function signatures for specific actions, and enhancing helper methods in the judo-ui-react module. These adjustments ensure consistent identifier usage and improve the clarity and functionality of the UiPageContainerHelper class by incorporating a new method for handling action definitions.

Changes

File Path	Change Summary
.../ActionGroupTest/…/AccessViewPage/index.tsx.snapshot	Updated identifiers in comments related to various creature-related actions
.../ActionGroupTest/…/AccessTablePage/index.tsx.snapshot	Modified comments' identifiers and adjusted function signatures for actions like createDarkMatterAction and others
.../ActionGroupTestPro/…/AccessTablePage/index.tsx.snapshot	Similar changes to identifiers in comments and function signatures as in the ActionGroupTest/…/AccessTablePage file
judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java	Introduced new getCallOperationName method and modified simpleActionDefinitionName method to utilize this addition

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UiPageContainerHelper

    User->>UiPageContainerHelper: Calls simpleActionDefinitionName
    UiPageContainerHelper->>UiPageContainerHelper: Checks ActionDefinition
    alt OperationType is Call
        UiPageContainerHelper->>UiPageContainerHelper: Calls getCallOperationName
    end
    UiPageContainerHelper-->>User: Returns Action Definition Name

Loading

Poem

From cosmos vast to tables grand,
We tweak, refine with careful hand.
In snapshots bright, identifiers change,
While helper methods rearrange.
New logic dawns in Java's core,
Enhancing flows forevermore.
Code evolves, a seamless dance,
In digital realms, we advance.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 696d5bf and bff05ae.

Files selected for processing (5)

• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Earth/AccessViewPage/index.tsx.snapshot (7 hunks)
• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (3 hunks)
• judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/Table/components/ViewGalaxyTableTableComponent/index.tsx.snapshot (3 hunks)
• judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (3 hunks)
• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (3 hunks)

Additional comments not posted (21)

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (3)

211-211: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

---

224-224: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

---

237-237: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (3)

211-211: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

---

224-224: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

---

237-237: Identifier updated correctly.

The identifier for OpenOperationInputFormAction has been updated correctly.

judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/Table/components/ViewGalaxyTableTableComponent/index.tsx.snapshot (3)

450-450: Identifier updated correctly.

The identifier for OperationFormTableRowCallOperationButton has been updated correctly.

---

466-466: Identifier updated correctly.

The identifier for OperationFormTableRowCallOperationButton has been updated correctly.

---

482-482: Identifier updated correctly.

The identifier for OperationFormTableRowCallOperationButton has been updated correctly.

judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (5)

90-90: Correct integration of getCallOperationName.

The simpleActionDefinitionName method now correctly uses getCallOperationName to generate the suffix.

---

92-92: Correct integration of getCallOperationName.

The simpleActionDefinitionName method now correctly uses getCallOperationName to generate the suffix for bulk actions.

---

96-96: Correct integration of getCallOperationName.

The simpleActionDefinitionName method now correctly uses getCallOperationName for selector actions.

---

102-102: Correct integration of getCallOperationName.

The simpleActionDefinitionName method now correctly uses getCallOperationName for form actions.

---

113-129: New method getCallOperationName added correctly.

The getCallOperationName method is correctly implemented to handle different types of action definitions based on OperationType.

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Earth/AccessViewPage/index.tsx.snapshot (7)

454-454: Update confirmed: ParameterlessCallOperationAction identifier.

The identifier has been updated correctly.

---

474-474: Update confirmed: OpenOperationInputFormAction identifier.

The identifier has been updated correctly.

---

487-487: Update confirmed: ParameterlessCallOperationAction identifier.

The identifier has been updated correctly.

---

507-507: Update confirmed: ParameterlessCallOperationAction identifier.

The identifier has been updated correctly.

---

527-527: Update confirmed: OpenOperationInputSelectorAction identifier.

The identifier has been updated correctly.

---

537-537: Update confirmed: OpenOperationInputSelectorAction identifier.

The identifier has been updated correctly.

---

547-547: Update confirmed: OpenOperationInputSelectorAction identifier.

The identifier has been updated correctly.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.