JNG-5842 fix missing refresh parameter

[noherczeg]

JNG-5842 Refresh parameter is missing from table hooks

[coderabbitai]

Walkthrough

This update introduces snapshot tests for enhancements in customization.ts in the AccessViewPage and AccessTablePage modules. It adds a refresh parameter to action hooks in God/Galaxies/AccessTablePage components and includes new type definitions for various data models and query customizers. Additionally, a method in UiPageContainerHelper.java is updated to check for table-specific refreshability based on action definitions.

Changes

File(s)	Change Summary
.../pom.xml	Added new sources customization.ts for snapshot testing.
.../AccessTablePage/customization.ts.snapshot	Introduced type declarations and a hook interface for extending ViewGalaxyTablePageActionsExtended.
.../AccessTablePage/index.tsx.snapshot	Updated customActions declaration to include refresh parameter for customActionsHook call.
.../AccessViewPage/customization.ts.snapshot	Added type definitions and a hook interface for actions on galaxy views.
.../AccessTablePage/index.tsx.snapshot	Added refresh parameter to customActionsHook call in GodGodGalaxiesAccessTablePage component.
judo-ui-react/src/main/java/.../UiPageContainerHelper.java	Updated containerIsRefreshable method to check for table-specific refreshability based on actions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant GodGodGalaxiesAccessTablePage
    participant customActionsHook
    participant refresh

    User->>GodGodGalaxiesAccessTablePage: Load Page
    GodGodGalaxiesAccessTablePage->>customActionsHook: Call with (data, editMode, refresh)
    customActionsHook-->>GodGodGalaxiesAccessTablePage: Return custom actions
    GodGodGalaxiesAccessTablePage->>User: Display Table with Custom Actions

Loading

Poem

In code where galaxies swirl and play,
Custom hooks and types pave the way,
Refreshing tables now with ease,
New snapshots capture all degrees.
A rabbit cheers this bright array,
As stars align in our display. 🌟

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0f5eed7 and 9dffe62.

Files selected for processing (6)

• judo-ui-react-itest/ActionGroupTest/action_group_test__god/pom.xml (1 hunks)
• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/customization.ts.snapshot (1 hunks)
• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (1 hunks)
• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessViewPage/customization.ts.snapshot (1 hunks)
• judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (1 hunks)
• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (1 hunks)

Files skipped from review due to trivial changes (1)

• judo-ui-react-itest/ActionGroupTest/action_group_test__god/pom.xml

Additional comments not posted (6)

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/customization.ts.snapshot (2)

1-2: LGTM!

The new type imports are necessary for the new type definition.

---

7-12: LGTM!

The new type definition aligns with the changes to include the refresh parameter, enhancing functionality.

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessViewPage/customization.ts.snapshot (2)

1-8: LGTM!

The new type imports are necessary for the new type definition.

---

13-20: LGTM!

The new type definition aligns with the changes to include the refresh and submit parameters, enhancing functionality.

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (1)

91-91: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to customActionsHook match the new signature.

judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/pages/God/God/Galaxies/AccessTablePage/index.tsx.snapshot (1)

91-91: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to customActionsHook match the new signature.

Verification successful

Let's re-run the script without specifying the file type to ensure we capture all occurrences of customActionsHook.

---

Let's extract and review the lines containing customActionsHook to ensure they all match the new signature.

---

Let's retrieve more context lines around each occurrence of customActionsHook to confirm the usage of the new signature with the refresh parameter.

---

Verification successful: All instances of customActionsHook match the new signature with the refresh parameter.

• The function calls to customActionsHook in the codebase have been updated to include the refresh parameter.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `customActionsHook` match the new signature.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type tsx -A 5 $'customActionsHook'

Length of output: 66

---

Script:

#!/bin/bash
# Description: Verify all function calls to `customActionsHook` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg 'customActionsHook'

Length of output: 4140

---

Script:

#!/bin/bash
# Extract and review the lines containing `customActionsHook` to ensure they all match the new signature.

# Extract the lines from the previous search results
rg 'customActionsHook' | grep -Eo '.*customActionsHook.*'

# Review the lines to ensure they include the `refresh` parameter
rg 'customActionsHook' -A 5 | grep 'customActionsHook'

Length of output: 8346

---

Script:

#!/bin/bash
# Retrieve more context lines around each occurrence of `customActionsHook` to confirm the new signature usage.

# Search for the function usage and include more context lines
rg 'customActionsHook' -A 10

Length of output: 21021

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1