JNG-5836 No confirmation dialog before parameter opener button

[gaborflorian]

JNG-5836 Conditional Confirmation Dialog isn't displayed when the condition element is not on the View/Table page

[coderabbitai]

Walkthrough

The recent changes enhance the user experience by introducing conditional rendering logic in various components of the Judo UI framework. By implementing checks for "opener" buttons, unnecessary action confirmations are avoided, ensuring that user interactions are smoother and more intuitive. This refinement optimizes the flow of button actions, allowing the interface to respond appropriately based on the type of button clicked.

Changes

Files	Change Summary
src/containers/dialog.tsx.hbs, src/containers/page.tsx.hbs	Added conditional rendering for buttons to skip action confirmation if identified as opener buttons.
src/containers/widget-fragments/button.hbs, src/containers/widget-fragments/buttongroup.hbs, src/containers/widget-fragments/flex.hbs	Introduced unless checks to prevent action call fragment rendering for opener buttons, improving control flow and user interaction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Button
    participant Dialog

    User->>Button: Click
    Button->>Button: Check if Opener
    alt Is Opener
        Button-->>User: No Action
    else Not Opener
        Button->>Dialog: Trigger Action Confirmation
        Dialog-->>User: Show Confirmation
    end

Loading

Poem

🐇 In the meadow where buttons play,
A check was added, hip-hip-hooray!
Opener buttons, you now glide,
No more confirmations, enjoy the ride!
With each click, the flow is bright,
A smoother path, oh what a sight! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.