Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNG-5889 bulk detect hidden by #450

Merged
merged 2 commits into from
Aug 22, 2024
Merged

JNG-5889 bulk detect hidden by #450

merged 2 commits into from
Aug 22, 2024

Conversation

noherczeg
Copy link
Contributor

@noherczeg noherczeg commented Aug 22, 2024 •
edited by github-actions bot
Loading

BugJNG-5889 Table page's bulk operation's hidden by condition's is ignored

@noherczeg noherczeg self-assigned this Aug 22, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 22, 2024 •
edited
Loading

Walkthrough

The changes involve enhancements to button visibility and enablement logic within various components of the judo-ui-react application. Modifications include the introduction of new parameters and conditions that consider the state of selected rows, allowing for more refined control over user interface elements related to table actions.

Changes

Files Change Summary
judo-ui-react/src/main/java/.../UiPageContainerHelper.java
judo-ui-react/src/main/java/.../UiWidgetHelper.java		 Added checks for hiddenBy and enabledBy properties in button visibility conditions, enhancing the logic for determining button states.
judo-ui-react/src/main/resources/actor/src/components/table/EagerTable.tsx.hbs
judo-ui-react/src/main/resources/actor/src/components/table/LazyTable.tsx.hbs		 Updated toolBarAction.enabled function to include a new parameter, getSelectedRows(), affecting the conditions for enabling toolbar actions based on selected items.
judo-ui-react/src/main/resources/actor/src/containers/components/table/index.tsx.hbs Modified enabled function signature to include a new parameter, selectedRows, reflecting the current selection state for determining button visibility.
judo-ui-react/src/main/resources/actor/src/utilities/table.ts.hbs Updated ToolBarActionProps interface by adding a selectedRows parameter to the enabled function, enhancing its capability to evaluate actions based on selections.
judo-ui-react/src/main/resources/actor/src/containers/View/Galaxy/Table/components/ViewGalaxyTableTableComponent/index.tsx.snapshot Added selectedRows parameter to multiple enabled function definitions, enhancing decision-making based on selected rows in the logic.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Table
    participant Toolbar

    User->>Table: Select Rows
    Table->>Toolbar: Update Selected Rows
    Toolbar->>Toolbar: Evaluate Visibility Conditions
    Toolbar->>User: Update Button States
Loading

🐇 In the code, a rabbit hops with glee,
🐰 For buttons now hide, as they please!
🎉 With selected rows, actions align,
🌟 In the UI, all will shine!
🥕 More logic, more fun, let’s play,
🐇 Happy coding, hip-hip-hooray!

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 936f4ff and 4272625.

Files selected for processing (3)
  • judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/components/table/EagerTable.tsx.snapshot (1 hunks)
  • judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/components/table/LazyTable.tsx.snapshot (1 hunks)
  • judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/Table/components/ViewGalaxyTableTableComponent/index.tsx.snapshot (9 hunks)
Additional comments not posted (8)
judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/components/table/EagerTable.tsx.snapshot (1)

427-427: Change Approved: Updated enabled method parameters.

The inclusion of getSelectedRows() in the enabled method parameters aligns with the goal of respecting hidden conditions for bulk operations. This change enhances the logic by considering selected rows.

judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/containers/View/Galaxy/Table/components/ViewGalaxyTableTableComponent/index.tsx.snapshot (6)

284-284: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

300-300: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

316-316: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

332-332: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

348-348: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

364-364: Change Approved: Added selectedRows parameter to enabled function.

The inclusion of selectedRows enhances the function's ability to make decisions based on the selected rows, aligning with the PR objective.

judo-ui-react-itest/ActionGroupTestPro/action_group_test_pro__god/src/test/resources/snapshots/frontend-react/src/components/table/LazyTable.tsx.snapshot (1)

610-610: Change Approved: Updated enabled method parameters.

The inclusion of getSelectedRows() in the enabled method parameters aligns with the goal of respecting hidden conditions for bulk operations. This change enhances the logic by considering selected rows.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@noherczeg noherczeg merged commit 0f43d84 into develop Aug 22, 2024
3 checks passed
@noherczeg noherczeg deleted the feature/JNG-5889-bulk-detect-hidden-by branch August 22, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madmat8 Madmat8 Madmat8 approved these changes

@gaborflorian gaborflorian gaborflorian approved these changes

@bencegelei bencegelei bencegelei approved these changes

@robertcsakany robertcsakany robertcsakany approved these changes

Assignees

@noherczeg noherczeg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@noherczeg @robertcsakany @bencegelei @gaborflorian @Madmat8