JNG-5888 filter context

[noherczeg]

JNG-5888 Handle empty cells with context menu filters on tables

[coderabbitai]

Walkthrough

The recent changes involve significant modifications to the filtering mechanisms within the EagerTable and LazyTable components by removing the onExcludeByCell prop. New filtering capabilities have also been introduced, including enhanced options in localization files that offer users more precise control over data visibility. Additionally, the filtering logic in utility files has been updated for clarity, and the version of the judo-ui-typescript-rest dependency in the pom.xml has been adjusted.

Changes

File	Change Summary
src/components/table/EagerTable.tsx, src/components/table/LazyTable.tsx	Removed onExcludeByCell prop, altering the filtering logic related to cell exclusions.
src/main/resources/actor/public/i18n/system_default.json.hbs,	Added new filter options in JSON files, enhancing filtering capabilities with comparison operations.
src/main/resources/actor/public/i18n/system_en-US.json.hbs,
src/main/resources/actor/public/i18n/system_hu-HU.json.hbs	Replaced old filtering keys with new terminology for clarity and added empty/non-empty filtering options.
src/components/table/ContextMenu.tsx.hbs	Removed onExcludeByCell from ContextMenuProps and added new filtering methods (filterByEmpty, filterByNonEmpty).
src/utilities/filter-helper.ts.hbs	Updated filter operation logic to replace old constants with new ones (isNotEmpty, isEmpty) for clarity.
pom.xml	Updated version of judo-ui-typescript-rest dependency to reflect new filtering context features.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EagerTable
    participant LazyTable
    participant ContextMenu

    User->>ContextMenu: Select filter option
    ContextMenu->>EagerTable: Apply filter
    ContextMenu->>LazyTable: Apply filter

Loading

🐇 In fields of green, I hop and play,
With filters bright, we clear the way.
No more exclusions, just options anew,
For empty and filled, we’ll see what’s true.
Hooray for the changes, let's all cheer,
Data's clear view, let’s spread the cheer! 🎉

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d382513 and 1c7682b.

Files selected for processing (1)

• judo-ui-react/src/main/resources/actor/public/i18n/system_hu-HU.json.hbs (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• judo-ui-react/src/main/resources/actor/public/i18n/system_hu-HU.json.hbs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.