JNG-5890 fix missing confirmation mask

[noherczeg]

JNG-5890 Action group's button's confirmation dialog's condition's attribute is not included in mask

[coderabbitai]

Walkthrough

The changes introduce modifications to the getMaskForView method in the UiPageContainerHelper class. A new collection of Button elements is created, and the method is enhanced to include additional attributes from these buttons in the generated mask. This allows for broader attribute processing related to button elements.

Changes

Files	Change Summary
judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java	Modified the getMaskForView method to collect Button elements and include their attributes in the mask generation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant UiPageContainerHelper
    participant Button
    participant MaskEntry

    Client->>UiPageContainerHelper: getMaskForView(pageDefinition, containerId)
    UiPageContainerHelper->>Button: collectVisualElementsMatchingCondition()
    Button-->>UiPageContainerHelper: return buttons
    UiPageContainerHelper->>UiPageContainerHelper: filter buttons for confirmation attributes
    UiPageContainerHelper->>MaskEntry: create mask with button attributes
    MaskEntry-->>UiPageContainerHelper: return mask
    UiPageContainerHelper-->>Client: return mask

Loading

Poem

Hop and skip, the buttons gleam,
Attributes added, a coder's dream.
With masks that grow, so bright and bold,
In the world of UI, new stories unfold.
A rabbit's cheer for changes made,
In code we trust, let joy cascade! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3c7be1c and e7610f5.

Files selected for processing (1)

• judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (2 hunks)

Additional comments not posted (3)

judo-ui-react/src/main/java/hu/blackbelt/judo/ui/generator/react/UiPageContainerHelper.java (3)

281-282: Collect visual elements of type Button.

The new set buttons is created to collect elements of type Button from the container. This is consistent with how inputs are collected for AttributeBased elements.

The code changes are approved.

---

282-283: Use collectVisualElementsMatchingCondition to populate buttons.

The collectVisualElementsMatchingCondition method is used to filter elements based on their type and populate the buttons set. This ensures consistency in how visual elements are collected.

The code changes are approved.

---

293-297: Expand attributeNames to include button-related attributes.

The attributeNames set is expanded to include names derived from the buttons collection. Specifically, it filters the buttons for those that have a non-null confirmation and a non-null confirmationCondition, extracting the name of the confirmationCondition to be added to attributeNames. This enhances the functionality of the method by allowing it to account for additional attributes associated with button elements.

The code changes are approved.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.