Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNG-5905 Fix tags component #454

Merged

Conversation

Madmat8
Copy link
Contributor

@Madmat8 Madmat8 commented Sep 4, 2024

BugJNG-5905 If an element has selected in Tags component, then elements with same representation are filtered out in query customizer of onAutoCompleteSearch

Copy link

coderabbitai bot commented Sep 4, 2024

Walkthrough

The changes involve modifications to the Tags component in the Tags.tsx.hbs file, including updates to import statements, the addition of a new property identifierAttribute in the TagsProps interface, and refinements to the component's internal logic. The handling of options in the Autocomplete component has been improved, enhancing overall functionality and maintainability.

Changes

Files Change Summary
judo-ui-react/src/main/resources/actor/src/components/widgets/Tags.tsx.hbs - Adjusted import order.
- Added `identifierAttribute: string

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TagsComponent
    participant Autocomplete

    User->>TagsComponent: Interacts with Tags
    TagsComponent->>Autocomplete: Trigger search with query
    Autocomplete->>TagsComponent: Return filtered options
    TagsComponent->>User: Display options
    User->>TagsComponent: Select option
    TagsComponent->>Autocomplete: Update selected option
    Autocomplete->>TagsComponent: Confirm selection
    TagsComponent->>User: Show selected tags
Loading

Poem

🐰
In the garden where tags bloom bright,
New identifiers bring pure delight.
With every click and search anew,
Options dance, a vibrant view.
Hops of joy, a code so neat,
Celebrate changes, oh what a treat!
🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aec4e21 and 687bf9c.

Files selected for processing (1)
  • judo-ui-react/src/main/resources/actor/src/components/widgets/Tags.tsx.hbs (9 hunks)
Files skipped from review as they are similar to previous changes (1)
  • judo-ui-react/src/main/resources/actor/src/components/widgets/Tags.tsx.hbs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Madmat8 Madmat8 changed the title Fix tags component JNG-5905 Fix tags component Sep 4, 2024
@Madmat8 Madmat8 merged commit 08ddb45 into develop Sep 4, 2024
3 checks passed
@Madmat8 Madmat8 deleted the feature/JNG-5905_fix_query_customizer_of_tags_component branch September 4, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants