JNG-6019 fix typeahead onChange

[noherczeg]

JNG-6019 Typeahead - selecting value from dropdown is ignored in payload and dropdown selection does not trigger edit mode

[coderabbitai]

Walkthrough

The changes involve modifications to the TextWithTypeAhead component in the TextWithTypeAhead.tsx.hbs file. A new line has been added to the onChange event handler of the Autocomplete component to invoke the onChange callback with the target value when the selection changes. Additionally, the onInputChange function now depends on ownerData, which may impact how input change events are processed. The overall structure, props, and error handling of the component remain unchanged.

Changes

File Path	Change Summary
judo-ui-react/src/main/resources/actor/src/components/widgets/TextWithTypeAhead.tsx.hbs	Added onChange(target); to Autocomplete's onChange handler and updated onInputChange to depend on ownerData.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Autocomplete
    participant ParentComponent

    User->>Autocomplete: Selects item
    Autocomplete->>ParentComponent: onChange(target)
    ParentComponent->>Autocomplete: Update state

Loading

🐇 "In the garden where changes bloom,
The TextWithTypeAhead finds more room.
With onChange now in play,
It shares its news without delay.
A hop, a skip, a joyful cheer,
For better chats, the time is near!" 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (3)

judo-ui-react/src/main/resources/actor/src/components/widgets/TextWithTypeAhead.tsx.hbs (3)

Line range hint 40-45: Consider removing redundant value state

The value state appears redundant as:

1. It mirrors ownerData[name]
2. The Autocomplete component directly uses ownerData[name] as its value prop
3. This could lead to state synchronization issues

Consider removing the value state and its related setValue calls since the value is already managed through ownerData[name]:

-  const [value, setValue] = useState<any>(ownerData[name] || null);
-
-  useEffect(() => {
-    setValue(ownerData[name] || null);
-  }, [ownerData[name]]);

---

Line range hint 82-89: Fix incorrect useMemo dependencies in onInputChange

The current implementation has several issues:

1. It depends on ownerData but doesn't use it directly
2. Uses value in comparison but it's not in the dependency array
3. Recreates unnecessarily on every ownerData change

Consider this fix:

  const onInputChange = useMemo(
    () => (event: any, val: string, reason: string) => {
-     if (value !== val && reason !== 'reset') {
+     if (reason !== 'reset') {
        onChange(val);
        propagateChange(val);
      }
    },
-   [ownerData],
+   [onChange, propagateChange],
  );

---

Line range hint 13-29: Improve type safety of the component

The component uses any type in several places which could lead to runtime errors. Consider adding proper typing:

- ownerData: any;
+ ownerData: Record<string, string | null>;

- getOptionLabel={(option: any) => option || ''}
+ getOptionLabel={(option: string | null): string => option || ''}

- isOptionEqualToValue={(option: any, value: any) => option === value}
+ isOptionEqualToValue={(option: string, value: string | null): boolean => option === value}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7d55107 and d617f58.

📒 Files selected for processing (1)

• judo-ui-react/src/main/resources/actor/src/components/widgets/TextWithTypeAhead.tsx.hbs (1 hunks)