JNG-6072 dialog from row lifecycle

[noherczeg]

JNG-6072 Running operations in dialogs where dialogs have been opened from a table row cause UI to crash

• if a certain operation effectively removed the row from the table from which we opened it
• the operation caused the root page to reload
• the reload removed the element from the table
• the dialog got notified that it should reload
• the reload caused the re-calculation to yield either a different instance (tried to get the same row index from a new set, holy shit) or undefined because there were no rows left

[coderabbitai]

Walkthrough

The pull request introduces defensive data handling improvements in React components, focusing on preventing potential crashes during data updates. The changes add conditional checks to ensure that data is valid before updating state, specifically addressing scenarios where rows might be removed from source tables while still being referenced in dialogs or subscriptions.

Changes

File	Change Summary
.../RelationViewPage/index.tsx.snapshot	Added null/undefined check before updating state in subscription data handling
src/dialogs/index.tsx.hbs	Enhanced error handling in useEffect hook with conditional data setting

Poem

🐰 In the realm of React's grand design,
Where data flows like a rabbit's line,
We guard against the null's dark spell,
With checks that make our components well!
No crash shall break our coding might,
Our logic dances, pure and bright! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

judo-ui-react/src/main/resources/actor/src/dialogs/index.tsx.hbs (1)

390-395: LGTM! Good defensive programming practice.

The added null check prevents crashes in edge cases where a row might be removed from the original table while being viewed in a dialog. This is a good defensive programming practice.

Consider adding error logging to track these edge cases for monitoring purposes.

 if (copy !== undefined && copy !== null) {
+  console.debug('Skipping data update due to null/undefined value', {
+    dataPath,
+    rootPageId,
+  });
   setData(copy);
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec9085d and 6dac403.

📒 Files selected for processing (2)

• judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/dialogs/View/Galaxy/Stars/RelationViewPage/index.tsx.snapshot (1 hunks)
• judo-ui-react/src/main/resources/actor/src/dialogs/index.tsx.hbs (1 hunks)

🔇 Additional comments (1)

judo-ui-react-itest/ActionGroupTest/action_group_test__god/src/test/resources/snapshots/frontend-react/src/dialogs/View/Galaxy/Stars/RelationViewPage/index.tsx.snapshot (1)

668-673: LGTM! Changes are consistent with the template.

The defensive null check implementation matches the changes in the template file, ensuring consistent behavior across the codebase.