Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JNG-4227 support string substitution #85

Merged
merged 4 commits into from
Nov 22, 2023
Merged

JNG-4227 support string substitution #85

merged 4 commits into from
Nov 22, 2023

Conversation

Madmat8
Copy link
Contributor

@Madmat8 Madmat8 commented Nov 17, 2023 •
edited by github-actions bot
Loading

Sub-taskJNG-4227 For String asttribute builder add support for String substitution. (`builder.withName(String.format("company-%03d", i))`. It would be better to write this: `builder.withName("company-%03d", i)`.)

@Madmat8 Madmat8 self-assigned this Nov 17, 2023
@Madmat8 Madmat8 requested review from noherczeg, robertcsakany, bencegelei and gaborflorian and removed request for noherczeg and robertcsakany November 17, 2023 14:19
@Madmat8 Madmat8 marked this pull request as ready for review November 17, 2023 14:20
@Madmat8 Madmat8 merged commit c1fe065 into develop Nov 22, 2023
3 checks passed
@Madmat8 Madmat8 deleted the feature/JNG-4227_support_string_substitution branch November 22, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborflorian gaborflorian gaborflorian approved these changes

@bencegelei bencegelei bencegelei approved these changes

@noherczeg noherczeg noherczeg approved these changes

@robertcsakany robertcsakany robertcsakany approved these changes

Assignees

@Madmat8 Madmat8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Madmat8 @robertcsakany @noherczeg @bencegelei @gaborflorian