DEV-4268: Fix namespace for Custom Properties #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, use qn to get qualified name as opposed to string formatting
jonathanherr
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally thought this "Unreadable Content" warning had to do with the namespace prefix on the
Propertiestag: python-openxml#1273 (comment)It did, in part, have to do with that. But in testing fixes, I thought that
opwas still wrong because:Propertiesto<op: Properties>and still got the issuecustom.xmlfiles without an nsprefix e.g.<Properties>However, after using the Open XML SDK Productivity Tool from dotnet I was able to determine that the issue was from the missing namespace prefix on the child tag
<property>This PR changes the prefix to the correct one,
opand adds the namespace prefix for all child elements<op:property>