Parallel transport dev #32
Conversation
There was a problem hiding this comment.
Just reiterating my comments below: Print statements should changed to Messages, we should expand the functionality that @MvdMeent added to KerrGeoOrbitPhases to also work for the FastSpec method. We also need to add a key for initial phases. These will be needed to get the source integration correct. @znasipak can implement these changes. The ParallelTransport subpackage appears to work, but I have nothing to compare the results against. It would be better if Lisa Drummond or Viktor Skoupý reviewed this subpackage
|
|
||
| assoc = Association[ | ||
| "a" -> a, | ||
| "p" -> p, | ||
| "e" -> e, | ||
| "Inclination" -> x, | ||
| "Parametrization"->"Mino", | ||
| "Parametrization"->"Phases", | ||
| "Energy" -> En, | ||
| "AngularMomentum" -> L, | ||
| "CarterConstant" -> Q, | ||
| "ConstantsOfMotion" -> consts, | ||
| "RadialFrequency" -> \[CapitalUpsilon]r, | ||
| "PolarFrequency" -> \[CapitalUpsilon]\[Theta], | ||
| "AzimuthalFrequency" -> \[CapitalUpsilon]\[Phi], |
There was a problem hiding this comment.
Should we add a "TimeFrequency" key as well?
There was a problem hiding this comment.
I have added it to the "Frequencies", but did not added a top level key, because I did not know what to best call it.
Kernel/ParallelTransport.m
Outdated
| @@ -245,11 +297,12 @@ | |||
| method = OptionValue["Method"]; | |||
| param = OptionValue["Parametrization"]; | |||
|
|
|||
| If[param =!= "Mino", Print["Only Mino time parametrization has been implemented for parallel transport."];Return[];]; | |||
| If[param =!= "Mino"&& param =!= "Phases", Print["Only Mino time parametrization has been implemented for parallel transport."];Return[];]; | |||
There was a problem hiding this comment.
We should change these Print statements to Messages
There was a problem hiding this comment.
I'll take care of this (and other) changes to ParallelTransport.m
Kernel/ParallelTransport.m
Outdated
| @@ -245,11 +297,12 @@ | |||
| method = OptionValue["Method"]; | |||
| param = OptionValue["Parametrization"]; | |||
|
|
|||
| If[param =!= "Mino", Print["Only Mino time parametrization has been implemented for parallel transport."];Return[];]; | |||
| If[param =!= "Mino"&& param =!= "Phases", Print["Only Mino time parametrization has been implemented for parallel transport."];Return[];]; | |||
There was a problem hiding this comment.
Another instance of a Print statement that we probably want to change to a Message
| @@ -277,6 +330,7 @@ | |||
|
|
|||
|
|
|||
| KerrParallelTransportFrameFunction[a_, p_, e_, x_, assoc_][\[Lambda]_/;StringQ[\[Lambda]] == False] := assoc["ParallelTransportedFrame"][\[Lambda]] | |||
| KerrParallelTransportFrameFunction[a_, p_, e_, x_, assoc_][\[Lambda]__] := assoc["ParallelTransportedFrame"][\[Lambda]] | |||
| KerrParallelTransportFrameFunction[a_, p_, e_, x_, assoc_][y_?StringQ] := assoc[y] | |||
There was a problem hiding this comment.
We should add Keys support to KerrParallelTransportFrameFunction, just as we have for KerrGeoOrbitFunction
2) replace print statements with proper warning messages.
…nded the TrajectoryOscillatory function association to the FastSpec method
…erturbationToolkit/KerrGeodesics into ParallelTransport_Dev Merging with Maarten's recent changes
Several improvements:
May need further updates on: