This repository has been archived by the owner on Jun 29, 2024. It is now read-only.
Alchemy fixed #1418
Open
Alchemy fixed #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes alchemy by ensuring the datums have unique names (they were being overwritten), corrects the crafting type at the top (was showing up in crafting instead of alchemy), more efficient usage of bottle subtypes amongst recipes via subtype_reqs = TRUE whilst also ensuring that it works regardless if you use obj/item/reagent_containers/glass/bottle or obj/item/reagent_containers/glass/bottle/rogue (this code uses both and the map has the non rogue version for some reason).
Stinky code freeze means players don't get to use this yet tho.
Tested this locally, fully works!