Fix local html file path resolution from the model name #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having two models with these names (an example):
dreamshaper_8
dreamshaper_8Inpainting
When resolving the html file name (using existing code) for the model dreamshaper_8, the file that is guessed might be dreamshaper_8Inpainting.html. And the wrong locale html is loaded for the model ...
This pull request addresses the issue by adding a test to check the length of the matched file, which should fix the issue for most of the use cases.
Arguably, this is not ideal as there might be some edge cases where this doesn't fix the issue. But, this will fix most of the issues and is definitely better that what we have now.