-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix countSetBits function #201
Comments
I'll take it! |
Awesome @dna113p ! I will apply the 'in progress' label. This buys you 24 hours- if you need more time, feel free to reach out and I will happily oblige! Thanks for contributing! |
Can I try this too? |
@buoyantair ! Let's give @dna113p an opportunity to resolve the requested changes in his pull request. This goes for all methods that currently exist in the project, but feel free to push up improvements, more documentation, or a more inclusive test suite after his pull request is merged in! Issue #69 requests this :) |
@buoyantair you may like tackling the composition functions. I know |
@ktilcu @BlakeGuilloud Instead I'll add a few functions :P I'll try to tackle the others tomorrow, its night so this is my last task :p |
There is currently a method called
countSetBits
that lives in/lib/countSetBits.js
.It is incomplete and needs to be fixed!
Acceptance Criteria:
yarn test countSetBits
results in tests passing.yarn lint
does not print any errors to the console!Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!
The text was updated successfully, but these errors were encountered: