Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countSetBits function #201

Closed
stillNovice opened this issue Oct 20, 2017 · 6 comments · Fixed by #204
Closed

Fix countSetBits function #201

stillNovice opened this issue Oct 20, 2017 · 6 comments · Fixed by #204

Comments

@stillNovice
Copy link
Contributor

stillNovice commented Oct 20, 2017

There is currently a method called countSetBits that lives in /lib/countSetBits.js.
It is incomplete and needs to be fixed!

Acceptance Criteria:

  1. Running yarn test countSetBits results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@dna113p
Copy link
Contributor

dna113p commented Oct 20, 2017

I'll take it!

@BlakeGuilloud
Copy link
Owner

Awesome @dna113p ! I will apply the 'in progress' label. This buys you 24 hours- if you need more time, feel free to reach out and I will happily oblige! Thanks for contributing!

@elevenpassin
Copy link
Contributor

Can I try this too?

@dna113p dna113p mentioned this issue Oct 20, 2017
4 tasks
@BlakeGuilloud
Copy link
Owner

@buoyantair ! Let's give @dna113p an opportunity to resolve the requested changes in his pull request.

This goes for all methods that currently exist in the project, but feel free to push up improvements, more documentation, or a more inclusive test suite after his pull request is merged in! Issue #69 requests this :)

@ktilcu
Copy link
Collaborator

ktilcu commented Oct 20, 2017

@buoyantair you may like tackling the composition functions. I know flow is taken but compose and pipe are probably still available. #155

@elevenpassin
Copy link
Contributor

elevenpassin commented Oct 20, 2017

@ktilcu @BlakeGuilloud Instead I'll add a few functions :P I'll try to tackle the others tomorrow, its night so this is my last task :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants