countSetBits implemented #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktilcu
reviewed
Oct 20, 2017
lib/unique.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| //Return the number of unique elements in the array | |||
There was a problem hiding this comment.
what should we do about complex items in arrays? like objects or other arrays? maybe just use strict equality checking (===)? A test for this situation would be very explanatory. Something like
const omg = {omg:1};
expect(unique([omg, {omg:1}, omg])).toBe(2); // or 1 if you have something else in mind.would help whoever implements this in the future.
ktilcu
reviewed
Oct 20, 2017
lib/unique.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| //Return the number of unique elements in the array | |||
|
|
|||
| function unique(arr) { | |||
There was a problem hiding this comment.
Maybe call it uniqueCount?
ktilcu
requested changes
Oct 20, 2017
|
@dna113p looks like there are some conflicts. Can you clean those up? I'm looking forward to getting this in for you. |
|
@dna113p Thanks for taking the feedback and updating your branch! I'll merge it in. If you could create the issue for your skeleton method that would be very helpful for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn lintdoes not trigger any linter errorsCloses #201