-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
countSetBits implemented #204
Merged
+37
−3
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2ef92bc
add countSetBits to lib/index.js
dna113p 3bf6273
implement countSetBits.js
dna113p 58a82ed
add new function
dna113p 1a59807
Merge https://github.com/BlakeGuilloud/ganon
dna113p f68ea79
resolve issues
dna113p 41280b9
fix conflict
dna113p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add new function
commit 58a82ede155a05aab1e5955b52d68e3a0ad3a86a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
//Return the number of unique elements in the array | ||
|
||
function unique(arr) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe call it |
||
//your code here | ||
return; | ||
} | ||
|
||
module.exports = unique; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
const { unique } = require("../lib"); | ||
|
||
describe("unique", () => { | ||
test("should find 1 unique number in [1]", () => { | ||
expect(unique([1])).toEqual(); | ||
}); | ||
|
||
test("should find 1 unique number in [5,5,5]", () => { | ||
expect(unique([5,5,5])).toEqual(1); | ||
}); | ||
|
||
test("should find 3 unique numbers in [1,2,3]", () => { | ||
expect(unique([1,2,3])).toEqual(3); | ||
}); | ||
}); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what should we do about complex items in arrays? like objects or other arrays? maybe just use strict equality checking (
===
)? A test for this situation would be very explanatory. Something likewould help whoever implements this in the future.