-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Existing Methods #69
Comments
I can work on this |
@cjhaviland I made some minor requests in your pr #164 - Thanks for your work!! |
2 tasks
Is this issue closed? |
Hey @newbazz ! This issue will never be closed as there is always room for improvement. Feel free to browse through some of the methods and if you feel like you can improve anything, do it! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are plenty of methods that could be improved upon, more clearly documented, or contain a better suite of tests surrounding them. Please feel free to jump in and help clean up some existing methods where you see fit!
Two great examples of well documented methods with great tests surrounding them are
permute.js
andcombinations.js
. Shoutout to @andreasgruenh for the work he did surrounding these features.The same rule applies for improving methods in that when you create a pull request, if you can, please be sure to accompany it with a skeleton method for someone else to work on!!
The text was updated successfully, but these errors were encountered: