Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Existing Methods #69

Open
BlakeGuilloud opened this issue Oct 17, 2017 · 5 comments
Open

Improve Existing Methods #69

BlakeGuilloud opened this issue Oct 17, 2017 · 5 comments

Comments

@BlakeGuilloud
Copy link
Owner

BlakeGuilloud commented Oct 17, 2017

There are plenty of methods that could be improved upon, more clearly documented, or contain a better suite of tests surrounding them. Please feel free to jump in and help clean up some existing methods where you see fit!

Two great examples of well documented methods with great tests surrounding them are permute.js and combinations.js. Shoutout to @andreasgruenh for the work he did surrounding these features.

The same rule applies for improving methods in that when you create a pull request, if you can, please be sure to accompany it with a skeleton method for someone else to work on!!

@luisvillalba
Copy link
Contributor

I can work on this

@cjhaviland
Copy link
Contributor

Refactored #55 in #164

@BlakeGuilloud
Copy link
Owner Author

@cjhaviland I made some minor requests in your pr #164 - Thanks for your work!!

@newbazz
Copy link

newbazz commented Oct 28, 2017

Is this issue closed?

@BlakeGuilloud
Copy link
Owner Author

Hey @newbazz ! This issue will never be closed as there is always room for improvement. Feel free to browse through some of the methods and if you feel like you can improve anything, do it! Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants