Add option for outputFilename #4
Conversation
|
I like the idea of this, but this doesn't work well when you have multiple css files. I think it would be a good idea to add support for predefined variables as well, e.g. |
|
Sure, that sounds like a good idea. I'll take a look and see if I can devise something along these lines. |
|
Okay, I gave it a shot. What do you think? First time writing webpack plugin code, so not sure I'm doing it right. |
|
Any feedback? I can also do it differently, if this is not what you had in mind. |
| basename = name.substring(name.lastIndexOf('/') + 1); | ||
| if (basename.lastIndexOf('.') !== -1) { | ||
| basename = basename.substring(0, basename.lastIndexOf('.')); | ||
| } |
There was a problem hiding this comment.
Could you use path.parse instead? Not all operating systems (i.e. Windows) use / as a path separator, using the NodeJS provided modules here gives cross platform support for free.
|
Sorry for the late reply, I was a bit pre-occupied. Other than the comment I gave it looks great! If you update it then I'll test and release it tomorrow. |
|
No problem, I've solved this with |
|
Sure, that's even better! |
|
Great, look forward to the tests / release. I didn't go ahead with writing tests for this because the plugin has been rebuilt in #2 anyway. I've added this as a comment for the other branch too. |
|
Any luck? |
|
@TiddoLangerak I guess this is not going to be merged, right? |
No description provided.